Update date data type casting #103

fivetran-reneeli · 2023-08-22T16:18:24Z

PR Overview

This PR will address the following Issue/Feature: #96

This PR will result in the following new package version:

0.11.2

Non breaking as these changes are under the hood and will not have visible impact on downstream model materializations.
This will also be in combo with PR #51 in the source

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

Update seeds and configs in the integration testing folder to match what was updated in the [source]( PR #51)

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

Before marking this PR as "ready for review" the following have been applied:

The appropriate issue has been linked and tagged
You are assigned to the corresponding issue and this PR
BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

You have validated these changes and assure this PR will address the respective Issue/Feature.
You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
You have provided details below around the validation steps performed to gain confidence in these changes.

Models should successfully run. Additionally will ask the customer to run on this branch as well.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

Package versioning has been appropriately indexed in the following locations:
- indexed within dbt_project.yml
- indexed within integration_tests/dbt_project.yml
CHANGELOG has individual entries for each respective change in this PR
[n/a] README updates have been applied (if applicable)
[ n/a] DECISIONLOG updates have been updated (if applicable)
[ n/a] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💃

CHANGELOG.md

fivetran-avinash

looks good with one small commit update! Make sure to revert packages.yml and test that buildkite passes before merging/releasing.

Co-authored-by: Avinash Kunnath <[email protected]>

fivetran-reneeli · 2023-08-28T17:33:11Z

reminder to change package deps before merging

fivetran-avinash

@fivetran-reneeli Re-reviewed! Left a few comments.

fivetran-avinash · 2023-08-29T16:44:50Z

CHANGELOG.md

@@ -1,3 +1,7 @@
+# dbt_quickbooks v0.11.2


@fivetran-reneeli Since we're not cutting a new release, would recommend making this like dbt_quickbooks v0.VERSION.VERSION since the next release could go to 0.11.2 or 0.12.0.

oh good point, it'll serve as a good reminder as well. updated!

fivetran-avinash · 2023-08-29T16:45:10Z

dbt_project.yml

@@ -1,7 +1,7 @@
 config-version: 2
 name: 'quickbooks'

-version: '0.11.1'
+version: '0.11.2'


Would just keep this as 0.11.1

fivetran-avinash · 2023-08-29T16:45:18Z

integration_tests/dbt_project.yml

@@ -1,6 +1,6 @@
 name: 'quickbooks_integration_tests'

-version: '0.11.1'
+version: '0.11.2'


Would just keep this as 0.11.1

fivetran-avinash · 2023-08-29T16:56:09Z

packages.yml

-    version: [">=0.9.0", "<0.10.0"]
+  # - package: fivetran/quickbooks_source
+  #   version: [">=0.10.0", "<0.11.0"]
+  - git: https://github.com/fivetran/dbt_quickbooks_source.git


standard reminder to revert before merging. Would recommend kicking off Buildkite again after the source branch is merged to make sure it works on the new version

fivetran-avinash · 2023-08-29T17:00:22Z

integration_tests/dbt_project.yml

@@ -61,9 +61,16 @@ vars:
    quickbooks_vendor_credit_identifier: "vendor_credit_data"
    quickbooks_vendor_identifier: "vendor_data"

+    using_purchase_order: True


Are these variables needed now? Or were they just used for testing?

(Not that the integration tests is used by outside customers, but I'm not sure if we want to set the alternative variable logic as the default for future dev work.)

Yeah I think that was there for testing. I'll remove it though

fivetran-avinash · 2023-08-29T17:05:32Z

integration_tests/seeds/bill_payment_line_data.csv

@@ -1,5 +1,5 @@
 bill_payment_id,index,_fivetran_synced,amount,bill_id,check_id,credit_card_charge_id,credit_card_credit_id,deposit_id,expense_id,journal_entry_id,linked_bill_payment_id,vendor_credit_id,bill_payment_credit_card_id
-23,0,2020-05-20 14:03:30,38757,19,,,,,,,,,
+23,0,2020-05-20 14:03:30,38757,19.25,,,,,,,,,


This is weird. I see the original value in the source seed file is 19.25 too, but why is bill_id a decimal? I might just recommend pushing both back to 19.

Ooh good catch, I'm not sure why that's there. I'll change those to 19

fivetran-avinash · 2023-08-29T20:12:54Z

@fivetran-reneeli New changes look good to me!

fivetran-jamie · 2023-08-29T21:48:39Z

CHANGELOG.md

@@ -1,3 +1,7 @@
+# dbt_quickbooks v0.VERSION.VERSION
+[This PR](https://github.com/fivetran/dbt_quickbooks/pull/103/files) includes the following updates:


should it be

Suggested change

[This PR](https://github.com/fivetran/dbt_quickbooks/pull/103/files) includes the following updates:

[PR #103](https://github.com/fivetran/dbt_quickbooks/pull/103/files) includes the following updates:

fivetran-jamie · 2023-08-29T21:49:16Z

CHANGELOG.md

@@ -1,3 +1,7 @@
+# dbt_quickbooks v0.VERSION.VERSION


if we are updating the packages.yml we gotta cut a release for the transform

True, updated this

add temp deps

b19d1be

fivetran-reneeli mentioned this pull request Aug 22, 2023

apply data types for dates fivetran/dbt_quickbooks_source#51

Merged

15 tasks

fivetran-reneeli added 2 commits August 22, 2023 11:52

update integration seeds and configs

a8f4978

add changelogl

8c13a3c

fivetran-reneeli requested a review from fivetran-avinash August 22, 2023 17:43

fivetran-reneeli self-assigned this Aug 22, 2023

fivetran-reneeli added 2 commits August 22, 2023 12:55

docs and change back packages deps

946237d

reset redshift dbt req to test on 1.6

20fc693

fivetran-avinash reviewed Aug 22, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fivetran-avinash approved these changes Aug 22, 2023

View reviewed changes

fivetran-reneeli and others added 4 commits August 23, 2023 00:01

Update CHANGELOG.md

8e7546c

Co-authored-by: Avinash Kunnath <[email protected]>

revert deps

8250886

make sure source branch fixes error

9fbc716

update deps

9c790b2

mirror upstream changes in source PR

15ebcce

fivetran-avinash reviewed Aug 29, 2023

View reviewed changes

fivetran-reneeli added 2 commits August 29, 2023 14:02

not releasing

89b774d

update deps

ee9c5e8

fivetran-jamie reviewed Aug 29, 2023

View reviewed changes

fivetran-reneeli added 4 commits August 29, 2023 18:27

move to breaking change

906d8cf

new docs

54cd158

update deps

2cf8dc6

update range

f6d4fb8

fivetran-reneeli merged commit 74da53b into main Aug 30, 2023
1 check passed

fivetran-reneeli deleted the bugfix/cast_data_types_dates branch August 30, 2023 21:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update date data type casting #103

Update date data type casting #103

fivetran-reneeli commented Aug 22, 2023 •

edited

Loading

fivetran-avinash left a comment

fivetran-reneeli commented Aug 28, 2023

fivetran-avinash left a comment

fivetran-avinash Aug 29, 2023

fivetran-reneeli Aug 29, 2023

fivetran-avinash Aug 29, 2023

fivetran-reneeli Aug 29, 2023

fivetran-avinash Aug 29, 2023

fivetran-reneeli Aug 29, 2023

fivetran-avinash Aug 29, 2023

fivetran-avinash Aug 29, 2023

fivetran-reneeli Aug 29, 2023

fivetran-avinash Aug 29, 2023

fivetran-reneeli Aug 29, 2023

fivetran-avinash commented Aug 29, 2023

fivetran-jamie Aug 29, 2023

fivetran-reneeli Aug 29, 2023

fivetran-jamie Aug 29, 2023

fivetran-reneeli Aug 29, 2023

		@@ -1,3 +1,7 @@
		# dbt_quickbooks v0.VERSION.VERSION
		[This PR](https://github.com/fivetran/dbt_quickbooks/pull/103/files) includes the following updates:

	[This PR](https://github.com/fivetran/dbt_quickbooks/pull/103/files) includes the following updates:
	[PR #103](https://github.com/fivetran/dbt_quickbooks/pull/103/files) includes the following updates:

Update date data type casting #103

Update date data type casting #103

Conversation

fivetran-reneeli commented Aug 22, 2023 • edited Loading

PR Overview

PR Checklist

Basic Validation

Detailed Validation

Standard Updates

dbt Docs

If you had to summarize this PR in an emoji, which would it be?

fivetran-avinash left a comment

Choose a reason for hiding this comment

fivetran-reneeli commented Aug 28, 2023

fivetran-avinash left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fivetran-avinash commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fivetran-reneeli commented Aug 22, 2023 •

edited

Loading