Feature/add union data #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmediate model files
… transform model files
…ests) and packages.yml file
fivetran-joemarkiewicz
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
@fivetran-jamie @fivetran-poonamagate great job on these PRs! I only have a few comments, but these look good to go with just a few comments to be addressed before merging.
.github/workflows/check_docs.yml
Outdated
| @@ -0,0 +1,35 @@ | |||
| name: 'check docs' | |||
There was a problem hiding this comment.
Same request as others to remove this file
README.md
Outdated
|
|
||
| <details><summary><i>Expand for source configuration template</i></summary><p> | ||
|
|
||
| > **Note**: If there are source tables you do not have (see [Step 4](https://github.com/fivetran/dbt_netsuite?tab=readme-ov-file#step-5-disable-models-for-non-existent-sources-netsuite2-only)), you may still include them, as long as you have set the right [variables](https://github.com/fivetran/dbt_netsuite?tab=readme-ov-file#step-5-disable-models-for-non-existent-sources-netsuite2-only) to `False`. Otherwise, you may remove them from your source definitions. |
There was a problem hiding this comment.
Same comment on asking how we can make this easier to maintain
Comment on lines
+2
to
+6
| # - package: fivetran/netsuite_source | ||
| # version: [">=0.9.0", "<0.10.0"] | ||
| - git: https://github.com/fivetran/dbt_netsuite_source.git | ||
| revision: feature/add-union-data | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to swap before release
fivetran-catfritz
changed the base branch from
main
to
release/v0.13.0-apr-2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Poonam Agate, Fivetran
Link the issue/feature request which this PR is meant to address
N/A
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
Provides the capability to union multiple Netsuite connectors together and leverage the source dependent models in this package
How did you validate the changes introduced within this PR?
Run the models amended in BigQuery
Which warehouse did you use to develop these changes?
BigQuery
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)