Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fivetran_platform__audit_user_activity.sql #107

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Dec 21, 2023

PR Overview

This PR will address the following Issue/Feature: Issue #105

This PR will result in the following new package version: v1.4.1

This will not be a breaking change as we are only adjusting a cte in the fivetran_platform__audit_user_activity model to only parse the JSON data for the actor_email on actor related logs. This should not impact the row counts or results of existing users. Instead this will help reduce compute and ensure there are no JSON parsing issues on historical data.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fixes

  • Adjusted the fivetran_platform__audit_user_activity model to parse the message_data json field to obtain the actor_email information only if the field contains actor.
    • This ensures the JSON parsing is only happening on the fields that are relevant. This will help reduce compute and avoid potential JSON parsing errors.

Under the Hood

  • Included auto-releaser GitHub Actions workflow to automate future releases.
  • Updated the maintainer PR template to resemble the most up to date format.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • [will regenerate after approval] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Please see the detailed validations provided within the Hex notebook included within the Height ticket. The validations included in the notebook include:

  • Validation that the row count of the fivetran_platform__audi_user_activity model is the same on both the live version and these changes.
  • Confirmation that the output of the ctes being modified are the same between both live and changed versions.

If you had to summarize this PR in an emoji, which would it be?

🎭

@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review December 21, 2023 18:42
@fivetran-jamie fivetran-jamie self-requested a review December 27, 2023 18:47
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! minor changelog comment but good to merge after generating docs

- main

jobs:
call-workflow-passing-data:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added secret

CHANGELOG.md Outdated Show resolved Hide resolved
@fivetran-catfritz fivetran-catfritz self-requested a review December 28, 2023 20:19
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit be9ee6b into main Jan 4, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants