More information about people connected to slide-show photo #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason for the extra Would it be simpler to use Also, can we remove the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5025 +/- ##
============================================
- Coverage 33.85% 33.81% -0.05%
- Complexity 11399 11405 +6
============================================
Files 1178 1179 +1
Lines 47559 47619 +60
============================================
- Hits 16103 16100 -3
- Misses 31456 31519 +63 ☔ View full report in Codecov by Sentry. |
|
Fine hy me. Nigel Osborne (mobile)On 14 Sep 2024, at 9:57 PM, Greg Roach ***@***.***> wrote:
Is there a reason for the extra <span class="wt-slide-show-link-name">?
Would it be simpler to use <li class="wt-slide-show-link">?
Also, can we remove the small? For accessibility, I'd prefer that text didn't go smaller than the default/baseline size.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
fisharebest
added a commit
that referenced
this pull request
Sep 14, 2024
* More information about people connected to slide-show photo PR related to forum discussion at : https://www.webtrees.net/index.php/forum/9-request-for-new-feature/39211-more-information-about-people-connected-to-photo#106897 * Update slide-show.phtml --------- Co-authored-by: Greg Roach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to forum discussion at : https://www.webtrees.net/index.php/forum/9-request-for-new-feature/39211-more-information-about-people-connected-to-photo#106897