-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update British Monarchs and Prime Ministers History files and Create a New Zealand Prime Ministers History File #4978
Conversation
Updated to include the death of HM Queen Elizabeth II and also added HM King Charles III
Added last two British Prime Ministers so file is now current
Premiers & Prime Ministers of New Zealand
Added new line to use the New Zealand Prime Ministers History File
Add the extra line to allow New Zealand Prime Ministers History File to work!
Edited and updated file to include Charles III as current Monarch
What is the reason for not including this pull request? |
I don't know Greg's reason (workload?), but I see a few possible issues:
|
The Kings/Queens are fine - but I can't accept just part of a PR. The new names are all inconsistent with existing ones - why Maybe the full/legal names are OK for the NZ data?
This is a question for the New Zealanders to answer. |
When I first added these files everything was current. It would not be that hard to update (my fault for not doing so earlier) as each new Prime Minister came into 'power'. And the current British PM list is by far more out of date than this one.
Nicknames are not required, however for those that do have them, as I understand, their nicknames were used publicly (in the Media etc) quite often. Notes might be a better way of providing the info. I have started adding notes to the Monarchs file.. It is pretty much a link to the individuals page on Wikipedia. I could if desired do this with the PMs files too..
It may be controversial. I can accept that. And for sure it can be removed. It is my personal choice to use Nu Tirani NOT Aotearoa.. I'm still new at this game and do not want to create 'issues' within the community.. Rick Malkin |
I cannot quite recall how I got 'full names' for those that have them. IT could have been from the Wikipedia pages. These could be standardised for consistency. I guess having full names might be consistent with how we our 'family data' could be deemed a standard. Worthy of debate..
As stated in last reply it can be removed.. It is my personal preference.. Rick Malkin P.S. I have not had any notifications of further comments made on this PR.. Hence slow response.. |
From my perspective, consistency is the most important issue. If we use Harold Wilson for example, then we should also use Boris Johnson. Those are the names they were recognised by, and unless they are your family members, there’s no need for more. So long as it’s easy for any user to add or remove data from a ‘history file’ or ‘timeline’ perhaps we should not worry too much? For example, I have a British social history events listing, and if I come across an event which may have been of interest to people in my tree, I like to add that. |
Updated PMs Names to that commonly used. Added Notes with links to Wikipedia pages for each PM. Not all have been done, this is an example of what has been suggested.
Removed Nu - Tirani Removed Full Names in preference to names commonly used.
Added Note Links for Queen Elizabeth II & Charles III as examples. Can be updated as required.
I have updated NewZealandPrimeMinisters.php removing 'Nu Tirani' and updating names to commonly used in New Zealand. Updated BritishPrimeMinisters.php PM names to commonly used and added NoteLinks to some PMs. Can be further updated as required. Updated BritishMonarchs.php adding two Note links. One to Elizabeth II and one to Charles III as examples. Can be updated as required. Rick M |
Hopefully corrected Errors
seems as if you only have to change tab-char and blank char in BritishMonarchs.php starting in the line with |
Hopefully resolved the format issue.. Thanks Franz
Either add wiki links to all entries or none of them.
Either add wiki links to all entries or none of them.
Add end date for Boris Johnson
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4978 +/- ##
============================================
+ Coverage 33.78% 33.81% +0.02%
Complexity 11405 11405
============================================
Files 1177 1179 +2
Lines 47513 47618 +105
============================================
+ Hits 16053 16100 +47
- Misses 31460 31518 +58 ☔ View full report in Codecov by Sentry. |
Make consistent with other similar modules
Add to list of core modules
…a New Zealand Prime Ministers History File (#4978) * Update BritishMonarchs.php Updated to include the death of HM Queen Elizabeth II and also added HM King Charles III * Update BritishPrimeMinisters.php Added last two British Prime Ministers so file is now current * Create NewZealandPrimeMinisters.php Premiers & Prime Ministers of New Zealand * Update ModuleService.php Added new line to use the New Zealand Prime Ministers History File * Update ModuleService.php Add the extra line to allow New Zealand Prime Ministers History File to work! * Update BritishMonarchs.php Edited and updated file to include Charles III as current Monarch * Update BritishPrimeMinisters.php Updated PMs Names to that commonly used. Added Notes with links to Wikipedia pages for each PM. Not all have been done, this is an example of what has been suggested. * Update NewZealandPrimeMinisters.php Removed Nu - Tirani Removed Full Names in preference to names commonly used. * Update BritishMonarchs.php Added Note Links for Queen Elizabeth II & Charles III as examples. Can be updated as required. * Update BritishMonarchs.php Hopefully corrected Errors * Update BritishMonarchs.php Hopefully resolved the format issue.. Thanks Franz * Update BritishMonarchs.php Either add wiki links to all entries or none of them. * Update BritishPrimeMinisters.php Either add wiki links to all entries or none of them. * Update BritishPrimeMinisters.php Add end date for Boris Johnson * Update NewZealandPrimeMinisters.php Make consistent with other similar modules * Update ModuleService.php Add to list of core modules --------- Co-authored-by: Greg Roach <[email protected]>
A small start to my contributions to WebTrees..
These files have been operational on my site so hopefully will be ok to add to main..
My apologies if I have created errors in the process, haven't quite got my head round modifying files and Commits and Pulls.. I do hope I have it right at this point
Updated The Above files added one and modified ModuleService.php to include line for New Zealand Prime Ministers
Rick Malkin
New Zealand - Nu Tirani