Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tabs to bootstrap grid #4860

Closed

Conversation

ddrury
Copy link
Contributor

@ddrury ddrury commented Jul 27, 2023

Replaced the containing table with a bootstrap grid. This fixes all the problems with content overflowing the right margin and even looks reasonable when the browser width is reduced such that the columns fold.

It only requires two new webtrees classes, primarily for theming, everthing else is pure bootstrap.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #4860 (e9b4297) into main (ebb4f7d) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4860      +/-   ##
============================================
- Coverage     30.97%   30.97%   -0.01%     
  Complexity    11368    11368              
============================================
  Files          1168     1168              
  Lines         47875    47877       +2     
============================================
  Hits          14828    14828              
- Misses        33047    33049       +2     
Files Changed Coverage Δ
app/Module/IndividualFactsTabModule.php 0.00% <0.00%> (ø)

@ddrury ddrury closed this Jul 28, 2023
@ddrury ddrury deleted the Convert_tabs_to_bootstrap_grid branch July 28, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant