phpstan now supports PHP8.4

fisharebest · Aug 27, 2024 · f077613 · f077613
1 parent 039a373
commit f077613
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/.github/workflows/phpstan.yaml b/.github/workflows/phpstan.yaml
@@ -11,7 +11,7 @@ jobs:
  strategy:
  matrix:
  operating-system: ['ubuntu-latest']
- php-version: ['8.2', '8.3' ]
+ php-version: ['8.2', '8.3', '8.4']
  fail-fast: false
 
  steps:

diff --git a/app/Services/GedcomImportService.php b/app/Services/GedcomImportService.php
@@ -768,7 +768,7 @@ private function createMediaObject(string $gedcom, Tree $tree): string
  }
 
  preg_match_all('/\n\d NOTE (.+(?:\n\d CONT.*)*)/', $gedcom, $matches);
- $notes = $matches[1] ?? [];
+ $notes = $matches[1];
 
  // Have we already created a media object with the same title/filename?
  $xref = DB::table('media_file')

diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -1239,6 +1239,12 @@
  'count' => 1,
  'path' => __DIR__ . '/app/Http/RequestHandlers/PendingChangesRejectChange.php',
 ];
+$ignoreErrors[] = [
+ // identifier: offsetAccess.notFound
+ 'message' => '#^Offset 1 does not exist on array\\{0\\?\\: string, 1\\?\\: string\\}\\.$#',
+ 'count' => 1,
+ 'path' => __DIR__ . '/app/Http/RequestHandlers/PhpInformation.php',
+];
 $ignoreErrors[] = [
  // identifier: argument.type
  'message' => '#^Parameter \\#2 \\$subject of function preg_match expects string, string\\|false given\\.$#',
@@ -4173,6 +4179,12 @@
  'count' => 1,
  'path' => __DIR__ . '/app/Report/ReportParserGenerate.php',
 ];
+$ignoreErrors[] = [
+ // identifier: offsetAccess.notFound
+ 'message' => '#^Offset int\\<0, max\\> does not exist on array\\{\\}\\.$#',
+ 'count' => 2,
+ 'path' => __DIR__ . '/app/Report/ReportParserGenerate.php',
+];
 $ignoreErrors[] = [
  // identifier: argument.type
  'message' => '#^Parameter \\#1 \\$array of function end expects array\\|object, array\\<int, string\\>\\|false given\\.$#',
@@ -4341,6 +4353,12 @@
  'count' => 1,
  'path' => __DIR__ . '/app/Report/ReportParserSetup.php',
 ];
+$ignoreErrors[] = [
+ // identifier: offsetAccess.notFound
+ 'message' => '#^Offset 1 does not exist on array\\{0\\?\\: string, 1\\?\\: non\\-falsy\\-string\\}\\.$#',
+ 'count' => 1,
+ 'path' => __DIR__ . '/app/Report/ReportParserSetup.php',
+];
 $ignoreErrors[] = [
  // identifier: offsetAssign.valueType
  'message' => '#^array\\<string\\>\\|string does not accept array\\<string\\>\\.$#',
@@ -5169,6 +5187,12 @@
  'count' => 1,
  'path' => __DIR__ . '/app/Services/PendingChangesService.php',
 ];
+$ignoreErrors[] = [
+ // identifier: offsetAccess.notFound
+ 'message' => '#^Offset 1 does not exist on array\\{0\\?\\: string, 1\\?\\: non\\-falsy\\-string\\}\\.$#',
+ 'count' => 1,
+ 'path' => __DIR__ . '/app/Services/PendingChangesService.php',
+];
 $ignoreErrors[] = [
  // identifier: method.notFound
  'message' => '#^Call to an undefined method Fisharebest\\\\Webtrees\\\\Family\\|Fisharebest\\\\Webtrees\\\\Individual\\:\\:childFamilies\\(\\)\\.$#',