move globals out and generate source maps

firehoseio · Jun 16, 2016 · 262e4ad · 262e4ad
1 parent 1b9dcfb
commit 262e4ad
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 8 deletions.
diff --git a/dist/firehose.js b/dist/firehose.js
diff --git a/dist/firehose.js.map b/dist/firehose.js.map
diff --git a/dist/firehose.vendor.js b/dist/firehose.vendor.js
diff --git a/dist/firehose.vendor.js.map b/dist/firehose.vendor.js.map
diff --git a/javascript/lib/globals.coffee → helpers/node.coffee b/javascript/lib/globals.coffee → helpers/node.coffee
@@ -1,13 +1,18 @@
-# xhr
-global.XMLHttpRequest = require("xmlhttprequest").XMLHttpRequest
+# Helper used to define browser globals that our node app needs
+# Defines
+# - window
+# - document
+# - location
+# - $
 
 # jQuery dependencies
 jsdom = require("jsdom")
 global.document = jsdom.jsdom("<html></html>")
 global.window = document.defaultView
 
-# Node environments need this, browsers implement it themselves
-global.WebSocket = require "ws"
+# this needs to be attached to the jsdom window object to override
+# jsdom's internal xmlhttprequest object
+window.XMLHttpRequest = require("xmlhttprequest").XMLHttpRequest
 
 # URIjs dependencies
 
@@ -21,3 +26,10 @@ global.location = window.location
 # You need to initialize it with a Window object
 global.$ = require "jquery"
 $(window)
+
+# Node environments need this, browsers implement it themselves
+global.WebSocket = require "ws"
+
+# Current version
+module.exports =
+  version: require("../package.json").version
diff --git a/javascript/index.js b/javascript/index.js
@@ -1,4 +1,7 @@
 if ("webpack" != process.env.NODE_ENV) {
   require("coffee-script/register");
+  __VERSION__ = require("../helpers/node").version
 }
-module.exports = require("./lib/firehose");
+
+exports = module.exports = require("./lib/firehose");
+exports.version = __VERSION__;
diff --git a/spec/javascripts/support/spec_helper.coffee b/spec/javascripts/support/spec_helper.coffee
@@ -1,3 +1,3 @@
 global.sinon = require "sinon"
-require "../../../javascript/lib/globals"
+require "../../../helpers/node"
 global.Firehose = require "../../../javascript/index"
diff --git a/webpack.config.coffee b/webpack.config.coffee
@@ -10,6 +10,7 @@ module.exports =
   output:
     path: path.join(__dirname, "dist")
     filename: "[name].js"
+  devtool: "source-map"
   plugins: [
     new webpack.DefinePlugin(
       "process.env":