Fix argument of BitsParser.load_qmgr_jobs in process_file method #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing bytes-like object (
file_data
) to bits_parser's (https://github.com/ANSSI-FR/bits_parser) methodbits/bits.py->load_file(cls, fp)
which expects str-like object (simple file path) , simply passfile_path
argument ofBitsParser.process_file
method.Here it is shown how passed argument is treated in
bits_parser/bits/bits.py->load_file
https://github.com/ANSSI-FR/bits_parser/blob/717337cd7a0f97561b77543fb0cebb4e7ce7c0b7/bits/bits.py#L47
Without this change BitsParser fails to parse old format qmgr state files (with .dat extension) with next exception: