Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ksagiyam/merge upstream #54

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Ksagiyam/merge upstream #54

merged 6 commits into from
Dec 19, 2024

Conversation

ksagiyam
Copy link

Merge upstream.

Firedrake tests: firedrakeproject/firedrake#3938

FIAT tests: firedrakeproject/fiat#121

mscroggs and others added 4 commits November 15, 2024 17:04
* Fix action space check

* ruff

* unsafe ruff

* symmetric space check

* fix import conflict
* ruff==0.8.0

* remove apply_default_restrictions()

---------

Co-authored-by: Matthew Scroggs <[email protected]>
@ksagiyam ksagiyam marked this pull request as draft December 18, 2024 12:43
* Fix action space check

* ruff

* unsafe ruff

* symmetric space check

* fix import conflict

* Type check Action arguments
@pbrubeck pbrubeck mentioned this pull request Dec 19, 2024
@ksagiyam ksagiyam marked this pull request as ready for review December 19, 2024 14:09
@ksagiyam ksagiyam requested a review from pbrubeck December 19, 2024 14:51
Copy link

@pbrubeck pbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and passes the tests.

@pbrubeck pbrubeck merged commit 1b7808b into master Dec 19, 2024
9 checks passed
@ksagiyam
Copy link
Author

Thanks, Pablo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants