-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated logging capabilities #398
Conversation
021b132
to
939f4bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this Jack, I think it's really helpful to have this pulled out from configuration.py
0bc75c0
to
9c5b7d5
Compare
bd7ca51
to
e436b48
Compare
There's more to come, I think I can get KSP residuals to be logged. I think what we need is a custom KSP monitor, like I have written here (but much simpler), which logs the exact same information that is output by |
de1f6ec
to
fc1183a
Compare
649b170
to
7ae29c2
Compare
I think this is ready for another review 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good. I can confirm that I have run an example in serial and in parallel on my machine and that the log files appear in the results directory for that example.
Thanks very much!
Fixes #394