Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for Petrov-Galerkin formulations #3923

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ksagiyam
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 12, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8143 ran7456 passed675 skipped12 failed

Copy link

github-actions bot commented Dec 12, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8137 ran6651 passed1474 skipped12 failed

Comment on lines 1188 to 1190
tensor_func = tensor.riesz_representation(riesz_map="l2")
if self._diagonal:
bc.set(tensor_func, 1)
else:
bc.apply(tensor_func)
bc.set(tensor_func, 1)
tensor.assign(tensor_func.riesz_representation(riesz_map="l2"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think bc.set does type checking, so the riesz_representation could go away. This will cause a conflict, as I also modified this code here #3922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants