Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a pip-installed libsupermesh #3920

Merged
merged 13 commits into from
Dec 20, 2024
Merged

Use a pip-installed libsupermesh #3920

merged 13 commits into from
Dec 20, 2024

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Dec 11, 2024 •
edited
Loading

Description

I may have figured out the secret sauce.

Merge with firedrakeproject/libsupermesh#11

TODOs

  • Amend pip install information

@connorjward connorjward added macOS and removed macOS labels Dec 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8139 ran6665 passed1474 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8145 ran7470 passed675 skipped0 failed

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real0 ran0 passed0 skipped0 failed

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex0 ran0 passed0 skipped0 failed

@connorjward connorjward force-pushed the connorjward/pip-install-libsupermesh branch from cf06d81 to 6580570 Compare December 13, 2024 09:48
@francesco-ballarin
Copy link
Member

Almost unrelated question, apologies for having missed the right time to ask: why are the requirements*.txt files still around? I thought everything had moved into pyproject.toml.

@connorjward
Copy link
Contributor Author

Almost unrelated question, apologies for having missed the right time to ask: why are the requirements*.txt files still around? I thought everything had moved into pyproject.toml.

They are parsed inside the firedrake-install script. Since firedrake-install will hopefully be going away very soon I don't want to spend a lot of time updating it which is why I have left them.

@connorjward connorjward force-pushed the connorjward/pip-install-libsupermesh branch from af6565f to de5a43f Compare December 18, 2024 11:04
connorjward
connorjward commented Dec 18, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
connorjward
connorjward commented Dec 18, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
connorjward
connorjward commented Dec 18, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
connorjward
connorjward commented Dec 18, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
connorjward
connorjward commented Dec 19, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
connorjward
connorjward commented Dec 19, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
connorjward
connorjward commented Dec 19, 2024
View reviewed changes
requirements-git.txt Outdated Show resolved Hide resolved
@connorjward connorjward marked this pull request as ready for review December 19, 2024 12:45
JDBetteridge
JDBetteridge previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get this in!

requirements-git.txt Outdated Show resolved Hide resolved
@connorjward connorjward merged commit 00127cc into master Dec 20, 2024
16 checks passed
@connorjward connorjward deleted the connorjward/pip-install-libsupermesh branch December 20, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDBetteridge JDBetteridge JDBetteridge left review comments

Assignees
No one assigned
Labels
macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjward @francesco-ballarin @JDBetteridge