Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all reduced functional arguments. #3908

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Add all reduced functional arguments. #3908

merged 6 commits into from
Dec 11, 2024

Conversation

Ig-dolci
Copy link
Contributor

@Ig-dolci Ig-dolci commented Dec 6, 2024

Description

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8138 ran7463 passed675 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8132 ran6658 passed1474 skipped0 failed

@Ig-dolci Ig-dolci marked this pull request as ready for review December 9, 2024 11:28
Ig-dolci
Ig-dolci commented Dec 10, 2024
View reviewed changes
firedrake/adjoint/ensemble_reduced_functional.py
super(EnsembleReducedFunctional, self).__init__(
J, control, derivative_components=derivative_components,
scale=scale, tape=tape, eval_cb_pre=eval_cb_pre,
eval_cb_post=eval_cb_post, derivative_cb_pre=derivative_cb_pre,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add hessian args

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

firedrake/adjoint/ensemble_reduced_functional.py Show resolved Hide resolved
firedrake/adjoint/ensemble_reduced_functional.py
tape : pyadjoint.Tape
A tape object that the reduced functional will use to evaluate the functional and
its gradients (or derivatives).
eval_cb_pre : :func:
Copy link
Contributor Author

@Ig-dolci Ig-dolci Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if eval_cb_pos is in the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dham dham merged commit a420cd0 into master Dec 11, 2024
16 of 20 checks passed
@dham dham deleted the dolci/add_rf_params_to_erf branch December 11, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dham dham dham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ig-dolci @dham