Ksagiyam/add periodic hex mesh #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/add_periodic_hex_mesh
branch
5 times, most recently
from
0eac3d0 to
2f847b8
Compare
|
Hi @ksagiyam, great that you are working on this! I was just looking for this feature and saw your PR. In the meantime, the corresponding PETsc PR https://gitlab.com/petsc/petsc/-/merge_requests/7677 has been merged. Do you know what is missing in your PR and do you intend to continue working on it? Otherwise, I could also take a look. |
|
I need to make this branch up-to-date. I also noticed that I had not labeled boundaries correctly, so I need to fix that. I will work on this later today. |
|
Thank you very much for your quick reply @ksagiyam ! I would be very happy if that works. But of course no hurry either. |
ksagiyam
force-pushed
the
ksagiyam/add_periodic_hex_mesh
branch
from
2f847b8 to
18a952f
Compare
|
|
ksagiyam
force-pushed
the
ksagiyam/add_periodic_hex_mesh
branch
from
396c0e9 to
8ff54b5
Compare
connorjward
reviewed
Dec 19, 2024
ksagiyam
force-pushed
the
ksagiyam/add_periodic_hex_mesh
branch
from
8ff54b5 to
7b5c3c0
Compare
connorjward
requested changes
Dec 19, 2024
Co-authored-by: Connor Ward <[email protected]>
|
Thanks, Connor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add periodic hex box mesh.
Depends on https://gitlab.com/petsc/petsc/-/merge_requests/7677.Merged.periodic+sparseLocalize=FalseinPETSc.DMPlex().createBoxMesh()(Firedrake requires DG coordinates on the entire domain),RelabeledMeshfor marking boundaries.