Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quadratures from gen-quad #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add quadratures from gen-quad #89

wants to merge 4 commits into from

Conversation

pbrubeck
Copy link

@pbrubeck pbrubeck commented Oct 16, 2024

Degree 16 - 22 tetrahedral quadrature rules computed with https://github.com/arkslobodkins/gen-quad

@pbrubeck
Copy link
Author

@wence- how should we give credit to the author?

@@ -0,0 +1,5823 @@
# GENERATED, DO NOT EDIT
# Slobodkins-Tausch quadratures
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest linking to the code repo (with a commit hash), so that someone else knows what was run to generate this.

Comment on lines +336 to +337
def gen_quad_simplex(dim):
ref_el = symmetric_simplex(dim)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the citation here as well?

@wence-
Copy link

wence- commented Oct 16, 2024

@wence- how should we give credit to the author?

We don't currently hook the Citations mechanism up in FIAT. Maybe we should. Then we could register all the citations for quadrature rules and it would be automatic for -citations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants