Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLL/GL on simplices with recursive points #46

Merged
merged 28 commits into from
Nov 9, 2023
Merged

Conversation

pbrubeck
Copy link

No description provided.

@pbrubeck pbrubeck requested review from dham and rckirby October 17, 2023 20:44
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems eminently reasonable. I had a few comments. Major point is whether we want to re-implement recursivenodes or create a dependency. It should be a simple install procedure and would give us more features and let us incrementally get rid of old code like for orthogonal bases! But before we embark on a major undertaking like that, we should probably see where elements, etc, wind up with ongoing UFL work.

FIAT/recursive_points.py Outdated Show resolved Hide resolved
FIAT/recursive_points.py Outdated Show resolved Hide resolved
Copy link

@rckirby rckirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think the discussion of using vs recreating recursivenodes is worth having, but it's probably best not to create a new dependency at this point?

FIAT/gauss_lobatto_legendre.py Show resolved Hide resolved
test/unit/test_gauss_legendre.py Outdated Show resolved Hide resolved
@tisaac
Copy link

tisaac commented Nov 2, 2023

I still think the discussion of using vs recreating recursivenodes is worth having, but it's probably best not to create a new dependency at this point?

You can compare the approaches in other projects.

  • The construction is intentionally simple and I had expected reimplementation to be the most common choice. This is what basix does.

  • At Andreas Klöckner's prodding, I kept the transitive requirements lightweight -- only numpy is required to generate the nodes -- so he has recursivenodes as a dependency in meshmode. The package is on an MIT license. I have not has reason to test the package with the latest python (its minimum requirement is 3.6), but am happy to address issues if they come up.

@rckirby rckirby merged commit 4eaa5e7 into master Nov 9, 2023
8 checks passed
@rckirby rckirby deleted the pbrubeck/recursive-nodes branch November 9, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants