Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add syscalls #34

Closed
wants to merge 6 commits into from
Closed

add syscalls #34

wants to merge 6 commits into from

Conversation

0x0ece
Copy link
Contributor

@0x0ece 0x0ece commented May 13, 2024

Do NOT merge, this is just a demo / wip.

This PR shows a path to run syscalls conformance tests using firedancer and solfuzz-agave.

  1. generators/syscalls_hash.py creates 3 tests for sha256, keccak256, blake3 (empty input => expect valid + correct output)
  2. vm.proto is taken from solfuzz-agave => we prob want a better way to keep all protos together, e.g. proto/ folder?
  3. test_suite has been hacked so that it can run SyscallContext instead of InstrContext and return SyscallEffect.
    • instead of duplicating all functions, a much better approach is probably to handle instr/syscall depending on the type
    • I don't want to create too much mess, so I leave architecture decision + refactor to someone else, this is just an example to see that it can work

@0x0ece 0x0ece marked this pull request as draft May 13, 2024 17:29
@0x0ece 0x0ece force-pushed the 0x0ece/syscalls branch from ceb407a to 7224872 Compare May 16, 2024 20:29
@0x0ece 0x0ece force-pushed the 0x0ece/syscalls branch from 7224872 to 67646e7 Compare May 22, 2024 17:29
@0x0ece 0x0ece closed this May 28, 2024
@0x0ece 0x0ece deleted the 0x0ece/syscalls branch May 28, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant