only print diff when failures

firedancer-io · Nov 6, 2024 · 3cadfac · 3cadfac
1 parent 7f89add
commit 3cadfac
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/test_suite/test_suite.py b/src/test_suite/test_suite.py
@@ -482,13 +482,14 @@ def run_tests(
     if failed != 0 and save_failures:
         print("Failures tests are in: ", globals.output_dir / "failed_protobufs")
 
-    binary_to_log_file = {
-        path.stem: log_file.name for path, log_file in target_log_files.items()
-    }
-    for (name1, file1), (name2, file2) in itertools.combinations(
-        binary_to_log_file.items(), 2
-    ):
-        print(f"Diff between {name1} and {name2}: vimdiff {file1} {file2}")
+    if failed != 0:
+        binary_to_log_file = {
+            path.stem: log_file.name for path, log_file in target_log_files.items()
+        }
+        for (name1, file1), (name2, file2) in itertools.combinations(
+            binary_to_log_file.items(), 2
+        ):
+            print(f"Diff between {name1} and {name2}: vimdiff {file1} {file2}")
 
 
 @app.command(help=f"Convert Context and/or Fixture messages to human-readable format.")