Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch: adding eah to snapshot tile and renaming to batch tile #3838

Merged
merged 1 commit into from
Jan 9, 2025
Merged

batch: adding eah to snapshot tile and renaming to batch tile #3838

merged 1 commit into from
Jan 9, 2025

Conversation

ibhatt-jumptrading
Copy link
Contributor

@ibhatt-jumptrading ibhatt-jumptrading commented Jan 3, 2025 •
edited
Loading

  1. Renaming snapshot tile to the batch tile
  2. Adding epoch account has calculation to the background
  3. leaving offline eah calculation to be blocking in this PR. Will address in follow up.

@ibhatt-jumptrading ibhatt-jumptrading changed the title batch: adding eah to snapshot tile and renaming batch: adding eah to snapshot tile and renaming [wip] Jan 3, 2025
@ibhatt-jumptrading ibhatt-jumptrading force-pushed the eah_in_bg branch 2 times, most recently from 8755a5e to 6cccd57 Compare January 6, 2025 22:54
@ibhatt-jumptrading ibhatt-jumptrading changed the title batch: adding eah to snapshot tile and renaming [wip] batch: adding eah to snapshot tile and renaming to batch tile Jan 6, 2025
@ibhatt-jumptrading ibhatt-jumptrading force-pushed the eah_in_bg branch 8 times, most recently from 386f8af to 46c111f Compare January 8, 2025 21:36
jumpsiegel
jumpsiegel previously approved these changes Jan 9, 2025
View reviewed changes
topointon-jump
topointon-jump previously approved these changes Jan 9, 2025
View reviewed changes
src/app/fdctl/run/tiles/fd_batch.c Outdated Show resolved Hide resolved
src/app/fdctl/run/tiles/fd_batch.c Show resolved Hide resolved
src/app/fdctl/run/tiles/fd_replay.c Show resolved Hide resolved
src/app/fdctl/run/tiles/fd_replay.c Outdated Show resolved Hide resolved
src/app/fdctl/run/tiles/fd_replay.c Outdated Show resolved Hide resolved
@ibhatt-jumptrading ibhatt-jumptrading added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 07a72b4 Jan 9, 2025
10 checks passed
@ibhatt-jumptrading ibhatt-jumptrading deleted the eah_in_bg branch January 9, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topointon-jump topointon-jump topointon-jump approved these changes

@jumpsiegel jumpsiegel jumpsiegel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibhatt-jumptrading @jumpsiegel @topointon-jump