Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh: default to Linux only machine types #3803

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

ripatel-fd
Copy link
Contributor

Fixes bug where CI tries to build macOS and FreeBSD builds on
a Linux environment without cross-compile infra

ShellCheck fixes:

  • SC2045: Iterating over ls output is fragile. Use globs
  • SC2145: Argument mixes string and array. Use * or separate argument.

Fixes bug where CI tries to build macOS and FreeBSD builds on
a Linux environment without cross-compile infra

ShellCheck fixes:
- SC2045: Iterating over ls output is fragile. Use globs
- SC2145: Argument mixes string and array. Use * or separate argument.
@ripatel-fd ripatel-fd force-pushed the ripatel/build-sh-no-cross branch from d347af1 to 2f542dd Compare December 30, 2024 07:27
@ripatel-fd ripatel-fd requested a review from anwayde December 30, 2024 07:28
@ripatel-fd
Copy link
Contributor Author

@anwayde Could you review this script and test it? On my box, the compilers are under /opt/rh not /opt/gcc so I can't test it myself.

@ripatel-fd ripatel-fd added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 440bf84 Dec 30, 2024
10 checks passed
@ripatel-fd ripatel-fd deleted the ripatel/build-sh-no-cross branch December 30, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants