quic: fix Identification field being always 0 #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a classic C typo with (*ptr++) syntax. The bug resulted in all Firedancer QUIC packets having an IPv4 ID field of 0. Most Internet peers (most notably Linux) are resilient enough to handle this. Should be fixed nonetheless.
riptl
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a classic C typo with (*ptr++) syntax.
The bug resulted in all Firedancer QUIC packets having an IPv4 ID
field of 0. Most Internet peers (most notably Linux) are resilient
enough to handle this. Should be fixed nonetheless.