Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: refactor fd_vm_log_appendf -> fd_vm_log_append_printf #1861

Merged
merged 1 commit into from
May 17, 2024
Merged

vm: refactor fd_vm_log_appendf -> fd_vm_log_append_printf #1861

merged 1 commit into from
May 17, 2024

Conversation

0x0ece
Copy link
Contributor

@0x0ece 0x0ece commented May 14, 2024

No description provided.

ripatel-fd
ripatel-fd requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a unit test that ensures behavior is correct in the normal case and in the case where the log buffer space is exhausted

@0x0ece 0x0ece force-pushed the 0x0ece/syscalls-logs2 branch from a696df2 to 0af9a21 Compare May 17, 2024 20:07
@0x0ece 0x0ece force-pushed the 0x0ece/syscalls-logs2 branch from 0af9a21 to 0458fd1 Compare May 17, 2024 20:49
@0x0ece 0x0ece merged commit 99a67c0 into vm-belt-sanding-public May 17, 2024
11 checks passed
@0x0ece 0x0ece deleted the 0x0ece/syscalls-logs2 branch May 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripatel-fd ripatel-fd ripatel-fd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x0ece @ripatel-fd