Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial set of changes need for repair service #1618

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

jumpsiegel
Copy link
Contributor

No description provided.

asiegel-jt
asiegel-jt previously approved these changes Apr 24, 2024
@asiegel-jt asiegel-jt changed the title repair service updates Partial set of changes need for repair service May 9, 2024
@asiegel-jt
Copy link
Contributor

repair_get_shred and repair_get_parent still need to be done, but this is enough for an initial merge

@asiegel-jt asiegel-jt requested a review from lheeger-jump May 9, 2024 18:08
src/app/fdctl/run/tiles/fd_repair.c Outdated Show resolved Hide resolved
lheeger-jump
lheeger-jump previously approved these changes May 10, 2024
@lheeger-jump
Copy link
Contributor

I am dubious of the ping mechanism. We will need to potentially time out these peers every so often.

@jumpsiegel jumpsiegel requested a review from lheeger-jump May 13, 2024 12:52
@asiegel-jt asiegel-jt enabled auto-merge May 13, 2024 13:25
@asiegel-jt asiegel-jt added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 43c9ccd May 13, 2024
11 checks passed
@asiegel-jt asiegel-jt deleted the repair-service branch May 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants