Invalid fd_log_thread_id on fdctl

[ripatel-fd]

/* fd_log_thread_id() returns the caller's integer thread id.  A thread
   id is intended, at a minimum, to be unique over all concurrently
   running threads in the application.  This is cheap after the first
   call. */

ulong fd_log_thread_id( void );

fd_log_thread_id returns mostly zero. Which is not "unique over all concurrently running threads in the application".
The runtime database code relies on fd_log_thread_id being unique

fd1:[group]:resolv:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:bank:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     1
fd1:[group]:quic:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:verify:1 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:bank:1 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     2
fd1:[group]:shred:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:sign:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:gui:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:verify:3 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:dedup:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:verify:5 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:pack:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:verify:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:verify:2 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:verify:4 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:plugin:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:metric:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:net:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0
fd1:[group]:bank:2 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     3
fd1:[group]:bank:3 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     4
fd1:[group]:poh:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     5
fd1:[group]:store:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     6
fd1:[group]:cswtch:0 src/disco/topo/fd_topo_run.c(133)[fd_topo_run_tile]: fd_log: --log-thread-id     0

[ripatel-fd]

Marking as high prio because it has the potential to break funk

[anoushk1234]

Marking as high prio because it has the potential to break funk

Is progress on this issue already underway? If not I can take it up