New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd_stem does not seed RNG #3645

Open

ripatel-fd opened this issue Dec 6, 2024 · 0 comments

Assignees

Labels

perf Priority: Low

Contributor

ripatel-fd commented Dec 6, 2024

firedancer/src/disco/stem/fd_stem.c

Line 693 in ce71e5c

FD_TEST( fd_rng_join( fd_rng_new( rng, 0, 0UL ) ) );

The rng used by stem should be seeded with the fd_log_thread_id. Depends on #3643

ripatel-fd added perf Priority: Low labels

ripatel-fd self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment