Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 24.10 to popular containers #4882

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Oct 30, 2024

Changes

  • Add Ubuntu 24.10 to the popular containers test, and remove 23.10
  • Drop some dead code supporting old releases.

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o marked this pull request as ready for review October 30, 2024 08:56
@pb8o pb8o self-assigned this Oct 30, 2024
@pb8o pb8o added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting author Indicates that an issue or pull request requires author action python Pull requests that update Python code labels Oct 30, 2024
And remove 23.10 since it is EOL

Signed-off-by: Pablo Barbáchano <[email protected]>
v1.6.0 has been EOL for a few months already.

Signed-off-by: Pablo Barbáchano <[email protected]>
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (e04cdfe) to head (a7ae361).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4882   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         251      251           
  Lines       28083    28083           
=======================================
  Hits        23619    23619           
  Misses       4464     4464           
Flag Coverage Δ
5.10-c5n.metal 84.68% <ø> (ø)
5.10-m5n.metal 84.66% <ø> (ø)
5.10-m6a.metal 83.96% <ø> (ø)
5.10-m6g.metal 80.78% <ø> (ø)
5.10-m6i.metal 84.65% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 80.78% <ø> (ø)
6.1-c5n.metal 84.67% <ø> (-0.01%) ⬇️
6.1-m5n.metal 84.66% <ø> (ø)
6.1-m6a.metal 83.97% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 80.78% <ø> (ø)
6.1-m6i.metal 84.65% <ø> (+<0.01%) ⬆️
6.1-m7g.metal 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Oct 30, 2024
@roypat roypat merged commit 2689dd6 into firecracker-microvm:main Oct 30, 2024
8 checks passed
@pb8o pb8o deleted the popular-2410 branch October 30, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` python Pull requests that update Python code Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants