Increase virtio-net queue size to 512 #4875
Merged
+76
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
net_queue_512
branch
2 times, most recently
from
5d48ede
to
ba3d75e
Compare
ShadowCurse
added
Status: Awaiting review
ShadowCurse
force-pushed
the
net_queue_512
branch
4 times, most recently
from
baed8d5
to
565258f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4875 +/- ##
==========================================
- Coverage 84.10% 84.09% -0.01%
==========================================
Files 251 251
Lines 28083 28074 -9
==========================================
- Hits 23619 23610 -9
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
net_queue_512
branch
3 times, most recently
from
0d6c513
to
61fec0a
Compare
bchalios
requested changes
Oct 29, 2024
ShadowCurse
force-pushed
the
net_queue_512
branch
2 times, most recently
from
d6cff6f
to
42aacca
Compare
bchalios
approved these changes
Oct 30, 2024
roypat
approved these changes
Oct 30, 2024
Add a const generic parameter to specify the length of the IovDeque. This way different devices can use different sizes for the queue. Signed-off-by: Egor Lazarchuk <[email protected]>
Increase of the queue size helps with keeping both vmm thread and guest busy at high network load and improves performance. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
net_queue_512
branch
from
6366bcb
to
de35bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make
IovDequeto have configurable size and increasevirtio-netqueue size to 512. This helps with keeping bothvmmthread and guest busy at high network load and improves performance.The increased queue size also leads to increased memory usage by 4 pages which is negligible compared to the overall VM memory usage.
Reason
Improved performance.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.