chore: Upload FCMetrics with reduced dimensions #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4405 +/- ##
=======================================
Coverage 81.53% 81.53%
=======================================
Files 241 241
Lines 29332 29332
=======================================
Hits 23916 23916
Misses 5416 5416
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
added 2 commits
January 25, 2024 18:21
FC metrics were uploaded to CW with the same dimensions as the test to make it easy to map the metrics with the test in CW. However, each test has a huge number of dimensions which when multiplied with the number of FC metrics we upload add upto too many datapoints stored in CW. This makes CW slow hard to monitor the dashboard and also has a significant increase in billing. So limit the dimensions to (cpu-host_version-guest_version) so that we can monitor the dashboard properly and reduce the billing. To map the datapoints with the test that emitted them we'll have to use the datapoint timestamp with some CW query. Signed-off-by: Sudan Landge <[email protected]>
FCMetricsMonitor class relies on `microvm` having a valid `kernel_file` to set guest kernel dimensions. sample_latency test restores microvm from snapshot so it didn't need to have a guest kernel passed while building microvm object. Passing guest kernel shouldn't affect the restore test but it will help FCMetricsMonitor to get the right guest kernel version so, update `sample_latency` to pass guest kernel while building the microvm. Signed-off-by: Sudan Landge <[email protected]>
wearyzen
added
the
Status: Awaiting review
pb8o
approved these changes
Jan 26, 2024
JonathanWoollett-Light
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FC metrics were uploaded to CW with the same dimensions as the test to make it easy to map the metrics with the test in CW. However, each test has a huge number of dimensions which when multiplied with the number of FC metrics we upload add upto too many datapoints stored in CW.
This makes CW slow hard to monitor the dashboard and also has a significant increase in billing.
So limit the dimensions to (cpu-host_version-guest_version) so that we can monitor the dashboard properly and reduce the billing. To map the datapoints with the test that emitted them we'll have to use the datapoint timestamp with some CW query.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.