test: add a test to check for nested virtualization #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4404 +/- ##
==========================================
+ Coverage 81.51% 81.53% +0.02%
==========================================
Files 241 241
Lines 29332 29332
==========================================
+ Hits 23910 23916 +6
+ Misses 5422 5416 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
force-pushed
the
add-nv-test
branch
2 times, most recently
from
4f329a0
to
482d206
Compare
pb8o
added
Priority: Medium
pb8o
force-pushed
the
add-nv-test
branch
2 times, most recently
from
5a95b66
to
d2aa9cc
Compare
pb8o
added
Status: Awaiting review
roypat
previously approved these changes
Jan 24, 2024
pb8o
added
Status: Awaiting author
Enabling those tests makes them currently fail. Skip for now while we investigate if they fail for valid reasons. Signed-off-by: Pablo Barbáchano <[email protected]>
This enables the tests that are not currently on CI. We should enable them only in Linux 6.1 since they won't work in any other kernel. Fixes: c358311 Signed-off-by: Pablo Barbáchano <[email protected]>
Check that nested virtualization is disabled in all our CPU templates. Other tests already check for CPU features explicitly, but this test just checks that virtualization is not available to the guest, however the means. Signed-off-by: Pablo Barbáchano <[email protected]>
Since we run them now as part of CI, there's no reason to run them separately here. Signed-off-by: Pablo Barbáchano <[email protected]>
Since we run this test twice in case of a PR, cargo audit locks the
database and one of the processes may print something (even with -q
specified) in stdout (‽). I believe this should be printed in stderr,
but we can workaround it here easily.
warning: directory /usr/local/rust/advisory-db is locked
{...}
Use `grep` to filter out the extraneous output.
Signed-off-by: Pablo Barbáchano <[email protected]>
roypat
approved these changes
Jan 25, 2024
JonathanWoollett-Light
approved these changes
Jan 25, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that nested virtualization is disabled in all our CPU templates.
Other tests already check for CPU features explicitly, but this test just checks that virtualization is not available to the guest, however the means.
Changes
[rev3]
fix: test_sec_audit. The test has failed 3 times in this PR, so I am including it even though it is unrelated.How tested
https://buildkite.com/firecracker/firecracker-pr/builds/8665#018d3caa-7488-44ee-a123-ea76ca15f318/55-278
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.