-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix markdown formatting and typos #4399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Type: Documentation
Indicates a need for improvements or additions to documentation
Status: Awaiting author
Indicates that an issue or pull request requires author action
labels
Jan 23, 2024
pb8o
changed the title
Some small doc fixes (typos / markdown formatting)
Fix markdown formatting and typos
Jan 23, 2024
pb8o
force-pushed
the
fix-docs
branch
2 times, most recently
from
January 23, 2024 12:45
9cb5477
to
b588bfb
Compare
pb8o
added
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
and removed
Status: Awaiting author
Indicates that an issue or pull request requires author action
labels
Jan 23, 2024
[Caution messages][1] are rendered nicely by GitHub's markdown renderer. [1]: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts Signed-off-by: Pablo Barbáchano <[email protected]>
For some reason they got moved out of place. Signed-off-by: Pablo Barbáchano <[email protected]>
Remove one footnote that is no longer relevant, and fix the formatting of the other one. Signed-off-by: Pablo Barbáchano <[email protected]>
Fix a typo of `linux_4.1` which should read `linux_4.14`. Signed-off-by: Pablo Barbáchano <[email protected]>
roypat
approved these changes
Jan 23, 2024
zulinx86
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
xmarcalx
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Type: Documentation
Indicates a need for improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some small markdown formatting fixes and typos
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
CHANGELOG.md
.TODO
s link to an issue.rust-vmm
.