Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown formatting and typos #4399

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Jan 23, 2024

Changes

Some small markdown formatting fixes and typos

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o self-assigned this Jan 23, 2024
@pb8o pb8o added Type: Documentation Indicates a need for improvements or additions to documentation Status: Awaiting author Indicates that an issue or pull request requires author action labels Jan 23, 2024
@pb8o pb8o changed the title Some small doc fixes (typos / markdown formatting) Fix markdown formatting and typos Jan 23, 2024
@pb8o pb8o force-pushed the fix-docs branch 2 times, most recently from 9cb5477 to b588bfb Compare January 23, 2024 12:45
@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Jan 23, 2024
For some reason they got moved out of place.

Signed-off-by: Pablo Barbáchano <[email protected]>
Remove one footnote that is no longer relevant, and fix the formatting
of the other one.

Signed-off-by: Pablo Barbáchano <[email protected]>
Fix a typo of `linux_4.1` which should read `linux_4.14`.

Signed-off-by: Pablo Barbáchano <[email protected]>
Copy link
Contributor

@zulinx86 zulinx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes

@xmarcalx xmarcalx merged commit 58fdc06 into firecracker-microvm:main Jan 23, 2024
5 checks passed
@pb8o pb8o deleted the fix-docs branch January 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants