Skip to content

Commit

Permalink
Merge branch 'main' into ab-simplification
Browse files Browse the repository at this point in the history
  • Loading branch information
roypat authored Oct 30, 2024
2 parents 20ca4b9 + 2689dd6 commit 01448e9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
4 changes: 0 additions & 4 deletions tests/framework/artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from pathlib import Path
from typing import Iterator

import packaging.version
import pytest

from framework.defs import ARTIFACT_DIR
Expand Down Expand Up @@ -98,9 +97,6 @@ def snapshot_version_tuple(self):
# independent of Firecracker versions. For these Firecracker versions, use
# the --snapshot-version Firecracker flag, to figure out which snapshot version
# it supports.
# TODO: remove this check once all version up to (and including) 1.6.0 go out of support.
if packaging.version.parse(self.version) < packaging.version.parse("1.7.0"):
return self.version_tuple[:2] + (0,)

return (
check_output([self.path, "--snapshot-version"])
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import subprocess
from pathlib import Path

import packaging.version
import pytest

from framework.utils import check_output
Expand All @@ -22,14 +21,6 @@ def test_describe_snapshot_all_versions(
snapshot state file.
"""

# TODO: remove this check once all versions prior to 1.6.0 go out of support.
if packaging.version.parse(firecracker_release.version) < packaging.version.parse(
"1.7.0"
):
pytest.skip(
"We can't parse snapshot files created from Firecracker with version < 1.7.0."
)

target_version = firecracker_release.snapshot_version
vm = microvm_factory.build(
guest_kernel,
Expand Down
2 changes: 1 addition & 1 deletion tools/test-popular-containers/build_rootfs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ EOF

make_rootfs alpine:latest
make_rootfs ubuntu:22.04
make_rootfs ubuntu:23.10
make_rootfs ubuntu:24.04
make_rootfs ubuntu:24.10
# make_rootfs ubuntu:latest

0 comments on commit 01448e9

Please sign in to comment.