Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove addVsocksHandler from loadSnapshotHandlerList #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove addVsocksHandler from loadSnapshotHandlerList #507

wants to merge 1 commit into from

Commits on Aug 24, 2023

  1. Remove addVsocksHandler from loadSnapshotHandlerList 

    According to the firecracker OpenAPI specification [1], creating vsock
devices is only a pre-boot request, so adding vsocks after loading a
snapshot fails. It also seems redundant, since the VM loaded from a
snapshot restores vsocks anyways.

Closes firecracker-microvm#506

1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678

Signed-off-by: Georgiy Lebedev <[email protected]>
    @CuriousGeorgiy
    CuriousGeorgiy committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6fe5d92 View commit details
    Browse the repository at this point in the history