New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Move `ImagenModelConfig` params to `ImagenGenerationConfig` #14340

Merged

andrewheard merged 1 commit into vertex-imagen from ah/vertex-rm-imagenmodelconfig

Jan 14, 2025

Contributor

andrewheard commented Jan 13, 2025 •

edited

Loading

Removed the ImagenModelConfig type and added its parameters to ImagenGenerationConfig.

Context:

It seems somewhat arbitrary to configure imageFormat at the model-level but aspectRatio at the request-level. This puts them both in the same place.
The addWatermark parameter only applies to image generation (not future upscaling or editing use cases) so it has been moved into ImagenGenerationConfig.

#14221
#no-changelog


          [Vertex AI] Move ImagenModelConfig params to ImagenGenerationConfig

1f401a6

andrewheard added the api: vertexai label

andrewheard marked this pull request as ready for review

January 13, 2025 21:11

andrewheard requested a review from paulb777

January 13, 2025 21:11

paulb777 approved these changes

View reviewed changes

andrewheard merged commit bb7dab5 into vertex-imagen

38 checks passed

andrewheard deleted the ah/vertex-rm-imagenmodelconfig branch

January 14, 2025 15:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels