-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vertex AI] Add ImagenGenerationConfig
to generateImages()
#14234
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
41 changes: 41 additions & 0 deletions
41
FirebaseVertexAI/Sources/Types/Public/Imagen/ImagenAspectRatio.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
// Copyright 2024 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
import Foundation | ||
|
||
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *) | ||
public struct ImagenAspectRatio { | ||
public static let square1x1 = ImagenAspectRatio(kind: .square1x1) | ||
|
||
public static let portrait9x16 = ImagenAspectRatio(kind: .portrait9x16) | ||
|
||
public static let landscape16x9 = ImagenAspectRatio(kind: .landscape16x9) | ||
|
||
public static let portrait3x4 = ImagenAspectRatio(kind: .portrait3x4) | ||
|
||
public static let landscape4x3 = ImagenAspectRatio(kind: .landscape4x3) | ||
|
||
let rawValue: String | ||
} | ||
|
||
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *) | ||
extension ImagenAspectRatio: ProtoEnum { | ||
enum Kind: String { | ||
case square1x1 = "1:1" | ||
case portrait9x16 = "9:16" | ||
case landscape16x9 = "16:9" | ||
case portrait3x4 = "3:4" | ||
case landscape4x3 = "4:3" | ||
} | ||
} |
34 changes: 34 additions & 0 deletions
34
FirebaseVertexAI/Sources/Types/Public/Imagen/ImagenGenerationConfig.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright 2024 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *) | ||
public struct ImagenGenerationConfig { | ||
public var numberOfImages: Int? | ||
public var negativePrompt: String? | ||
public var aspectRatio: ImagenAspectRatio? | ||
public var imageFormat: ImagenImageFormat? | ||
public var addWatermark: Bool? | ||
|
||
public init(numberOfImages: Int? = nil, | ||
negativePrompt: String? = nil, | ||
aspectRatio: ImagenAspectRatio? = nil, | ||
imageFormat: ImagenImageFormat? = nil, | ||
addWatermark: Bool? = nil) { | ||
self.numberOfImages = numberOfImages | ||
self.negativePrompt = negativePrompt | ||
self.aspectRatio = aspectRatio | ||
self.imageFormat = imageFormat | ||
self.addWatermark = addWatermark | ||
} | ||
} |
29 changes: 29 additions & 0 deletions
29
FirebaseVertexAI/Sources/Types/Public/Imagen/ImagenImageFormat.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Copyright 2024 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
import Foundation | ||
|
||
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *) | ||
public struct ImagenImageFormat { | ||
let mimeType: String | ||
let compressionQuality: Int? | ||
|
||
public static func png() -> ImagenImageFormat { | ||
return ImagenImageFormat(mimeType: "image/png", compressionQuality: nil) | ||
} | ||
|
||
public static func jpeg(compressionQuality: Int? = nil) -> ImagenImageFormat { | ||
return ImagenImageFormat(mimeType: "image/jpeg", compressionQuality: compressionQuality) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Still considering whether these should be mutable. It does make it significantly easier to adjust individual parameters and the config can be assigned to a
let
if the developer wants to keep them immutable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking aloud here... I've been thinking about what configuration types like this should look like in Swift 6. Here is my current thinking on the options:
ImageGenerationConfig
(async for the builder, sync for the produced value)