Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Migrate away from macos-12 in performance.yml #14131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Nov 15, 2024

Related to #11903

#no-changelog

@ncooke3 ncooke3 changed the title [Infra] Migrate away fromm macos-12 in performance.yml [Infra] Migrate away from macos-12 in performance.yml Nov 15, 2024
@ncooke3
Copy link
Member Author

ncooke3 commented Nov 15, 2024

Edit: I think #11903 is still valid because pod gen locally reveals the failures, but it's weird that the tests passed on CI...

@ncooke3
Copy link
Member Author

ncooke3 commented Nov 15, 2024

Hmm, looks like xcbeautify doesn't surface a failing exit code when tests crash (cpisciotta/xcbeautify#175):

https://github.com/firebase/firebase-ios-sdk/actions/runs/11862154195/job/33061011258?pr=14131#step:6:893

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like xcbeautify doesn't surface a failing exit code when tests crash

This was a good catch. Let's investigate what to do next before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants