-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Replace xcpretty
with xcbeautify
in build.sh
#13983
Conversation
VertexAITestApp-SPM.xcscheme
xcpretty
with xcbeautify
in build.sh
xcpretty
with xcbeautify
in build.shxcpretty
with xcbeautify
in build.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline warnings and test failures are neat! It's not critical, but there are some other hits for xcpretty cleanup.
nickcooke@nickcooke-mac firebase-3 % git grep xcpretty
.github/workflows/combine.yml: - name: Install xcpretty
.github/workflows/combine.yml: run: gem install xcpretty
.github/workflows/combine.yml: - name: Install xcpretty
.github/workflows/combine.yml: run: gem install xcpretty
.github/workflows/database.yml: - name: Install xcpretty
.github/workflows/database.yml: run: gem install xcpretty
.github/workflows/health-metrics-presubmit.yml: - name: Install xcpretty
.github/workflows/health-metrics-presubmit.yml: run: gem install xcpretty
.github/workflows/messaging.yml: - name: Install xcpretty
.github/workflows/messaging.yml: run: gem install xcpretty
.github/workflows/performance-integration-tests.yml: - name: Install xcpretty
.github/workflows/performance-integration-tests.yml: run: gem install xcpretty
.github/workflows/performance.yml: - name: Install xcpretty
.github/workflows/performance.yml: run: gem install xcpretty
.github/workflows/remoteconfig.yml: - name: Install xcpretty
.github/workflows/remoteconfig.yml: run: gem install xcpretty
.github/workflows/sessions-integration-tests.yml: - name: Install xcpretty
.github/workflows/sessions-integration-tests.yml: run: gem install xcpretty
.github/workflows/storage.yml: - name: Install xcpretty
.github/workflows/storage.yml: run: gem install xcpretty
.github/workflows/zip.yml: - name: Install xcpretty
.github/workflows/zip.yml: run: gem install xcpretty
IntegrationTesting/CocoapodsIntegrationTest/scripts/build_with_environment.sh: xcodebuild "${parameters[@]}" | xcpretty; result=$?
scripts/check_firestore_symbols.sh: | xcpretty
scripts/check_firestore_symbols.sh: | xcpretty
scripts/install_prereqs.sh:function install_xcpretty() {
scripts/install_prereqs.sh: gem install xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/install_prereqs.sh: install_xcpretty
scripts/setup_quickstart.sh:gem install xcpretty
scripts/test_archiving.sh:gem install xcpretty
scripts/test_archiving.sh:xcodebuild "${args[@]}" | xcpretty
scripts/test_catalyst.sh:gem install xcpretty
scripts/test_catalyst.sh:xcodebuild "${args[@]}" | xcpretty
Agreed! I thought that was pretty cool. I'll also ping our GChat groups in case the functionality surprises or alarms anyone.
Thanks for the reminder! If the FR gets closed I'll re-open until they're all handled. |
Replaced
xcpretty
withxcbeautify
inbuild.sh
to see if this results in passing tests showing up in log output. This starts implementing the FR #8566.Notes:
xcbeautify
is included by default in the GitHub action runner images (e.g., macOS 14 arm64).vertexai / testapp-integration
tests (working withxcbeautify
).#no-changelog