Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nc/custom signal #13976

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Nc/custom signal #13976

wants to merge 11 commits into from

Commits on Oct 7, 2024

  1. [Config] Add custom signal setter API

    @ncooke3
    ncooke3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2455ff8 View commit details
    Browse the repository at this point in the history

  2. Make API test clearer

    @ncooke3
    ncooke3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    372538c View commit details
    Browse the repository at this point in the history

  3. Rename to CustomSignal to CustomSignalValue

    @ncooke3
    ncooke3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2d840c4 View commit details
    Browse the repository at this point in the history

  4. Work for interpolated strings cc: @andrewheard

    @ncooke3
    ncooke3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4a25d7b View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Add support for deleting key

    @ncooke3
    ncooke3 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4c2bc89 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Complete implementation for setting/updating custom signals with tests

    @tusharkhandelwal8
    tusharkhandelwal8 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a8e3617 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Fix lint errors and code formatting.

    @tusharkhandelwal8
    tusharkhandelwal8 committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    b047554 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Set minimum iOS version to 13 for setCustomSignals

    @tusharkhandelwal8
    tusharkhandelwal8 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8d0f566 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Add limits, input validation, and unit tests for custom signals

    @tusharkhandelwal8
    tusharkhandelwal8 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    aebbcf5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Move last completionHandler block outside if condition

    @tusharkhandelwal8
    tusharkhandelwal8 committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    b2de614 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Add limits as constants and dispatch all completion blocks to global … 

    …queue.
    @tusharkhandelwal8
    tusharkhandelwal8 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    548eefe View commit details
    Browse the repository at this point in the history