Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Prefer completion handler APIs in Core Internal #13954

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 22, 2024

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Hide whitespace" makes this file easier to review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good safety improvement until we can fully to async

@ncooke3 ncooke3 marked this pull request as ready for review October 22, 2024 21:25
@ncooke3 ncooke3 merged commit 181c7c8 into nc/hotfix-2 Oct 22, 2024
58 checks passed
@ncooke3 ncooke3 deleted the nc/hotfix-2-alt branch October 22, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants