[Infra] Update Package.swift for Firebase 11

[ncooke3]

No description provided.

[google-oss-bot]

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

[ncooke3]

investigating one of the failures:

 ./scripts/build.sh objc-import-test macOS spm

Testing failed:
	xctest (57642) encountered an error (Failed to load the test bundle. (Underlying Error: The bundle “objc-import-test” couldn’t be loaded. The bundle couldn’t be loaded. Try reinstalling the bundle. dlopen(/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/objc-import-test.xctest/Contents/MacOS/objc-import-test, 0x0109): Library not loaded: @rpath/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop
  Referenced from: <E8432472-463F-30FF-A84E-F48A84A05863> /Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/FirebaseFirestoreInternal.framework/Versions/A/FirebaseFirestoreInternal
  Reason: tried: '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/PackageFrameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Applications/Xcode_15.2.app/Contents/SharedFrameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Xcode/Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/FirebaseFirestoreInternal.framework/Versions/A/Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/PackageFrameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/PackageFrameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/objc-import-test.xctest/Contents/MacOS/Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/objc-import-test.xctest/Contents/MacOS/../Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/PackageFrameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/PackageFrameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/objc-import-test.xctest/Contents/MacOS/Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-anxqgakbhyqozfhbkutiwmcpphvm/Build/Products/Debug/objc-import-test.xctest/Contents/MacOS/../Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/PrivateFrameworks/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file), '/Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib/FirebaseAppCheckInterop.framework/Versions/A/FirebaseAppCheckInterop' (no such file)))

Swapping the test action for build-for-testing got it to work.

Addressable by #13303

[ncooke3]

Another failure similar to the objc-import-test failure:
https://github.com/firebase/firebase-ios-sdk/actions/runs/9981192175/job/27587471962?pr=13301#step:7:182

[paulb777]

Sorry I saw that in the review and thought I was missing something about how the objc tests would need to change but not the swift ones.

[ncooke3]

idea– perhaps the issue is from testing a test target that does not have a test case.
nevermind.

[ncooke3]

https://github.com/firebase/firebase-ios-sdk/actions/runs/9993711581/job/27621729698?pr=13309#step:8:7402

Still trying to figure out why some test targets are running and others are failing to boot.

[ncooke3]

hint:

Referenced from: <D3A695DB-7FCC-3252-A994-431966D3BBB2> /Users/runner/Library/Developer/Xcode/DerivedData/firebase-ios-sdk-dkhlbuenaibuowhffbszhgvmwpqa/Build/Products/Debug-iphonesimulator/FirebaseFirestoreInternal.framework/FirebaseFirestoreInternal

and likewise for Analytics

Still trying to determine if this is a bug or if the Package.swift structure should change following the switch to dylibs

[ncooke3]

Latest failure is reproducible by opening Package.swift on this branch and testing the swift-test scheme. Currently investigating if this failure is something we can ignore or if it could surface for clients.

[ncooke3]

This may be more serious than I thought.

Also reproducible when:

• close out of firebase package window in Xcode
• xed IntegrationTesting/ClientApp/ClientApp.xcodeproj
• wait for package dependency to resolve
• run on iOS
• app crashes due to missing dylibs

dyld[69198]: Library not loaded: @rpath/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop
  Referenced from: <D3A695DB-7FCC-3252-A994-431966D3BBB2> /Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/FirebaseFirestoreInternal.framework/FirebaseFirestoreInternal
  Reason: tried: '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/FirebaseFirestoreInternal.framework/Frameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/usr/lib/swift/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file, not in dyld cache), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/usr/lib/swift/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file, not in dyld cache), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/FirebaseAppCheckInterop.framework/FirebaseAppCheckInterop' (no such file)Library not loaded: @rpath/FirebaseCore.framework/FirebaseCore
  Referenced from: <D539558B-0E76-342C-8AEF-7E8E00F8784F> /Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/FirebaseAnalytics.framework/FirebaseAnalytics
  Reason: tried: '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/FirebaseCore.framework/FirebaseCore' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/FirebaseCore.framework/FirebaseCore' (no such file), '/usr/lib/swift/FirebaseCore.framework/FirebaseCore' (no such file, not in dyld cache), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/FirebaseAnalytics.framework/Frameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/FirebaseCore.framework/FirebaseCore' (no such file), '/usr/lib/swift/FirebaseCore.framework/FirebaseCore' (no such file, not in dyld cache), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/FirebaseCore.framework/FirebaseCore' (no such file), '/usr/lib/swift/FirebaseCore.framework/FirebaseCore' (no such file, not in dyld cache), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/FirebaseCore.framework/FirebaseCore' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/FirebaseCore.framework/FirebaseCore' (no such file)Library not loaded: @rpath/GoogleUtilities.framework/GoogleUtilities
  Referenced from: <C701E120-87E8-3638-A48C-ADA1DA5D857A> /Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/GoogleAppMeasurement.framework/GoogleAppMeasurement
  Reason: tried: '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/GoogleAppMeasurement.framework/Frameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/GoogleUtilities.framework/GoogleUtilities' (no such file), '/usr/lib/swift/GoogleUtilities.framework/GoogleUtilities' (no such file, not in dyld cache), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/usr/lib/swift/GoogleUtilities.framework/GoogleUtilities' (no such file), '/usr/lib/swift/GoogleUtilities.framework/GoogleUtilities' (no such file, not in dyld cache), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Users/nickcooke/Library/Developer/Xcode/DerivedData/ClientApp-djblmlhooktwjtbhxgacxbggeuog/Build/Products/Debug-iphonesimulator/PackageFrameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Users/nickcooke/Library/Developer/CoreSimulator/Devices/B9B420C6-087C-4AD1-9A87-910E9CBE5526/data/Containers/Bundle/Application/9FFD2B78-8492-4CD8-B8DB-64CC3C0E3D71/ClientApp.app/Frameworks/GoogleUtilities.framework/GoogleUtilities' (no such file), '/Library/Developer/CoreSimulator/Volumes/iOS_21C62/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS 17.2.simruntime/Contents/Resources/RuntimeRoot/System/Library/Frameworks/GoogleUtilities.framework/GoogleUtilities' (no such file)

[ncooke3]

Narrowing down the issue: running otool -L on Analytics binary will show that it's looking for FirebaseCore.framework but SPM/Xcode does not seem smart enough to build FirebaseCore as a dylib because it's a dependency of Analytics

[ncooke3]

It's likely that the wrapper targets we use for the binary targets are no longer necessary when using dylibs. I'm going to try:

• removing the wrapper targets
• manually setting our libary targets to have type dynamic