Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode 15 runtime warning #11825

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix Xcode 15 runtime warning #11825

merged 2 commits into from
Sep 19, 2023

Conversation

paulb777
Copy link
Member

Fix #11821

@google-oss-bot
Copy link

google-oss-bot commented Sep 19, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.74% (a69962d) to 94.70% (3cd70d5) by -0.05%.

    FilenameBase (a69962d)Merge (3cd70d5)Diff
    FPRGaugeManager.m97.39%95.42%-1.96%
    FPRNSURLSessionInstrument.m97.55%97.56%+0.02%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/wL759tT1IE.html

andrewheard
andrewheard approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and your comment provides nice context!

@paulb777 paulb777 merged commit d14db42 into master Sep 19, 2023
48 checks passed
@paulb777 paulb777 deleted the pb-perf-xc15 branch September 19, 2023 21:10
@paulb777 paulb777 added this to the 10.16.0 - M138 milestone Sep 19, 2023
andrewheard pushed a commit that referenced this pull request Sep 20, 2023
@paulb777 @andrewheard
Fix Xcode 15 runtime warning (#11825)
c0cccb4
@paulb777 paulb777 mentioned this pull request Oct 6, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@visumickey visumickey visumickey approved these changes

@themiswang themiswang Awaiting requested review from themiswang

Assignees
No one assigned
Labels
api: performance
Projects
None yet
Milestone
10.16.0 - M138
Development

Successfully merging this pull request may close these issues.

Runtime warning in FPRNSURLSessionInstrument when running on iOS 17 RC built with Xcode 15 RC
4 participants
@paulb777 @google-oss-bot @visumickey @andrewheard