Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to clang-format v17 #11824

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Upgrade to clang-format v17 #11824

merged 2 commits into from
Sep 19, 2023

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Sep 19, 2023 •
edited
Loading

Switched to the Homebrew clang-format@17 formula since clang-format@16 is no longer available and ran scripts/style.sh.

#no-changelog

ncooke3
ncooke3 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is a clang-format@16 referenced in CONTRIBUTING.md

@ncooke3 ncooke3 mentioned this pull request Sep 19, 2023
Merged
@andrewheard
Copy link
Contributor Author

Also, there is a clang-format@16 referenced in CONTRIBUTING.md

Thanks for catching, @ncooke3! Updated.

paulb777
paulb777 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge with a green check CI

@andrewheard andrewheard enabled auto-merge (squash) September 19, 2023 16:51
@paulb777 paulb777 enabled auto-merge (squash) September 19, 2023 16:56
@paulb777
Copy link
Member

Bypassing all CI runs since the relevant ones have run and this is blocking other PRs

@paulb777 paulb777 merged commit a69962d into master Sep 19, 2023
40 checks passed
@paulb777 paulb777 deleted the ah/clang-format-17 branch September 19, 2023 16:59
andrewheard added a commit that referenced this pull request Sep 19, 2023
@andrewheard
Upgrade to clang-format v17 (#11824)
ef8b45c
andrewheard added a commit that referenced this pull request Sep 20, 2023
@andrewheard
Upgrade to clang-format v17 (#11824)
6526812
paulb777 pushed a commit that referenced this pull request Sep 28, 2023
@andrewheard @paulb777
Upgrade to clang-format v17 (#11824)
5ec3d5d
@firebase firebase locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewheard @paulb777 @ncooke3 @google-oss-bot