Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Consolidate Config and ConfigSwift #11808

Merged
merged 20 commits into from
Oct 13, 2023
Merged

[Config] Consolidate Config and ConfigSwift #11808

merged 20 commits into from
Oct 13, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 14, 2023

Context

  • The contents of RC's Swift extension SDK has been moved into the main RC module, and the RC Swift extension SDK now re-exports the API that used to live in it.
  • This change should be non-breaking.

Tasks

  • The affected extension podspecs should be versioned to pin to the releasing version.
  • When this PR is merged, stage the affected podspecs and notify the Games team.

Important

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Apple API Diff Report

Commit: 301698d
Last updated: Thu Oct 12 10:34 PDT 2023
View workflow logs & download artifacts


FirebaseRemoteConfigSwift

[REMOVED] Structures
Swift:
-    @available(iOS 14.0, macOS 11.0, tvOS 14.0, watchOS 7.0, *) @propertyWrapper public struct RemoteConfigProperty < T > : DynamicProperty where T : Decodable
-      public let key : String
-      public var wrappedValue : T { get }
-      public init ( key : String , fallback : T )
[REMOVED] Enumerations
Swift:
-    public enum RemoteConfigCodableError : Error
-      case invalidSetDefaultsInput ( String )
-    public enum RemoteConfigValueCodableError : Error
-      case unsupportedType ( String )
[REMOVED] Extensions
Swift:
-    public extension RemoteConfig
-      func decoded < Value > ( asType : Value . Type = Value . self ) throws -> Value where Value : Decodable
-      func setDefaults < Value > ( from value : Value ) throws where Value : Encodable
-      subscript < T > ( decodedValue key : String ) -> T ? where T : Decodable { get }
-      subscript ( jsonValue key : String ) -> [ String : AnyHashable ]? { get }
-    public extension RemoteConfigValue
-      func decoded < Value > ( asType : Value . Type = Value . self ) throws -> Value where Value : Decodable

@google-oss-bot
Copy link

google-oss-bot commented Sep 14, 2023

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from ? (1e0f294) to 72.24% (301698d) by ?.

    18 individual files with coverage change

    FilenameBase (1e0f294)Merge (301698d)Diff
    Codable.swift?0.00%?
    FIRConfigValue.m?58.70%?
    FirebaseRemoteConfigValueDecoderHelper.swift?0.00%?
    FIRRemoteConfig.m?83.91%?
    FIRRemoteConfigComponent.m?97.06%?
    FIRRemoteConfigUpdate.m?100.00%?
    RCNConfigContent.m?81.90%?
    RCNConfigDBManager.m?76.43%?
    RCNConfigExperiment.m?86.55%?
    RCNConfigFetch.m?74.13%?
    RCNConfigRealtime.m?50.63%?
    RCNConfigSettings.m?62.81%?
    RCNDevice.m?81.29%?
    RCNPersonalization.m?89.74%?
    RCNUserDefaultsManager.m?98.43%?
    RemoteConfigProperty.swift?0.00%?
    RemoteConfigValueObservable.swift?0.00%?
    Value.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eQ1p1ky8pL.html

Package.swift Show resolved Hide resolved
@ncooke3 ncooke3 merged commit 85f4f03 into master Oct 13, 2023
76 checks passed
@ncooke3 ncooke3 deleted the rc-swift-merged branch October 13, 2023 18:53
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants