Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for existence filter with updated, removed, added documents #11782

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Add test cases for existence filter with updated, removed, added documents #11782

merged 4 commits into from
Sep 8, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 6, 2023 •
edited
Loading

#no-changelog
ported from: firebase/firebase-js-sdk#7457

@milaGGL milaGGL self-assigned this Sep 6, 2023
@google-oss-bot
Copy link

google-oss-bot commented Sep 6, 2023 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (2eccf79)Merge (e48558d)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7GLQ4kVfm1.html

@google-oss-bot
Copy link

google-oss-bot commented Sep 6, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.21% (0e3f78b) to 88.14% (9d227d0) by -0.08%.

    FilenameBase (0e3f78b)Merge (9d227d0)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.63%98.82%+0.20%
    leveldb_opener.cc77.54%78.99%+1.45%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    ordered_code.cc93.90%94.39%+0.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/m2nBcOv62o.html

dconeybe
dconeybe requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one ultranit. Other than that, looks great!

Firestore/Example/Tests/Integration/API/FIRQueryTests.mm Outdated Show resolved Hide resolved
@dconeybe
Copy link
Contributor

dconeybe commented Sep 7, 2023

Thanks for porting this test!

@milaGGL milaGGL merged commit a08f405 into master Sep 8, 2023
41 checks passed
@milaGGL milaGGL deleted the mila/add-bloom-filter-test-cases branch September 8, 2023 15:40
andrewheard pushed a commit that referenced this pull request Sep 20, 2023
@milaGGL @andrewheard
Add test cases for existence filter with updated, removed, added docu…
94569a6 
…ments (#11782)
@firebase firebase locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milaGGL @google-oss-bot @dconeybe