Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: FIRQueryTests.mm: Replace SortedStringsNotIn() custom function #11649

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Firestore: FIRQueryTests.mm: Replace SortedStringsNotIn() custom function #11649

merged 1 commit into from
Aug 15, 2023

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Aug 4, 2023 •
edited
Loading

In Firestore's FIRQueryTests.mm, replace the hand-written SortedStringsNotIn() function with the standard XCTAssertEqualObjects() invoked with NSSet arguments. There was no reason to re-invent the wheel.

#no-changelog

@dconeybe
Firestore: FIRQueryTests.mm: Replace SortedStringsNotIn() custom func…
dbb60e2 
…tion with the standard XCTAssertEqualObjects() with NSSet instances.
@dconeybe dconeybe self-assigned this Aug 4, 2023
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.07% (d4beb34) to 88.06% (672acea) by -0.01%.

    FilenameBase (d4beb34)Merge (672acea)Diff
    leveldb_remote_document_cache.cc94.61%96.41%+1.80%
    ordered_code.cc94.39%93.90%-0.49%
    serializer.cc91.10%90.80%-0.31%
    watch_stream.cc95.35%90.70%-4.65%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AFORXDitR0.html

@dconeybe dconeybe marked this pull request as ready for review August 5, 2023 00:17
@dconeybe dconeybe requested a review from milaGGL August 5, 2023 00:17
milaGGL
milaGGL approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@dconeybe dconeybe merged commit 7a59c55 into master Aug 15, 2023
35 checks passed
@dconeybe dconeybe deleted the dconeybe/SortedStringsNotInToXCTAssertEqualObjects branch August 15, 2023 14:44
@firebase firebase locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @milaGGL