Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Aggregate query order-by normalization #11635

Merged

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented Aug 1, 2023

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

#no-changelog

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Aug 1, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.06% (a4ee260) to 88.06% (f8fcbad) by +0.00%.

    FilenameBase (a4ee260)Merge (f8fcbad)Diff
    grpc_nanopb.cc100.00%94.87%-5.13%
    leveldb_remote_document_cache.cc94.61%96.41%+1.80%
    query.cc98.45%98.51%+0.06%
    watch_stream.cc95.35%90.70%-4.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OX64x2jPHq.html

Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, overall LGTM

Firestore/core/test/unit/core/query_test.cc Show resolved Hide resolved
Firestore/core/src/core/query.h Outdated Show resolved Hide resolved
Firestore/core/test/unit/core/query_test.cc Show resolved Hide resolved
@MarkDuckworth MarkDuckworth merged commit 45c3004 into master Aug 4, 2023
35 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/non-normalized-aggregation-order-by branch August 4, 2023 15:55
@firebase firebase locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants