Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HeartbeatsPayload using incorrect year format #11611

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Fix HeartbeatsPayload using incorrect year format #11611

merged 1 commit into from
Jul 26, 2023

Conversation

Cyberbeni
Copy link
Contributor

YYYY = year according to "Week of year" format
yyyy = regular year, that matches with the year-month-day format

@paulb777 paulb777 requested a review from ncooke3 July 26, 2023 13:57
ncooke3
ncooke3 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@ncooke3 ncooke3 merged commit 2cdbbb7 into firebase:master Jul 26, 2023
42 checks passed
ncooke3 added a commit that referenced this pull request Jul 26, 2023
@ncooke3
[CoreInternal] Add regression test for fix in #11611
c2974b6
@ncooke3 ncooke3 mentioned this pull request Jul 26, 2023
Merged
ncooke3 added a commit that referenced this pull request Jul 26, 2023
@ncooke3
[CoreInternal] Add regression test for fix in #11611 (#11613)
4084532
@firebase firebase locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cyberbeni @ncooke3 @benedek-kozma-zenitech