Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared application fix #11554

Merged
merged 2 commits into from
Jul 25, 2023
Merged

shared application fix #11554

merged 2 commits into from
Jul 25, 2023

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Jul 14, 2023 •
edited
Loading

#no-changelog

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Jul 14, 2023 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (9205183)Merge (b9b4b01)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dFKzkExU4I.html

@google-oss-bot
Copy link

google-oss-bot commented Jul 15, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from ? (9205183) to 68.90% (b9b4b01) by ?.

    117 individual files with coverage change

    FilenameBase (9205183)Merge (b9b4b01)Diff
    FIRActionCodeSettings.m?100.00%?
    FIRAdditionalUserInfo.m?92.31%?
    FIRAuth.m?80.49%?
    FIRAuthAPNSToken.m?100.00%?
    FIRAuthAPNSTokenManager.m?55.62%?
    FIRAuthAppCredential.m?91.30%?
    FIRAuthAppCredentialManager.m?100.00%?
    FIRAuthBackend+MultiFactor.m?37.89%?
    FIRAuthBackend.m?82.20%?
    FIRAuthCredential.m?38.89%?
    FIRAuthDataResult.m?41.38%?
    FIRAuthDefaultUIDelegate.m?0.00%?
    FIRAuthDispatcher.m?100.00%?
    FIRAuthErrorUtils.m?72.27%?
    FIRAuthExceptionUtils.m?0.00%?
    FIRAuthGlobalWorkQueue.m?100.00%?
    FIRAuthKeychainServices.m?59.66%?
    FIRAuthNotificationManager.m?84.68%?
    FIRAuthProtoFinalizeMFAPhoneRequestInfo.m?0.00%?
    FIRAuthProtoFinalizeMFAPhoneResponseInfo.m?0.00%?
    FIRAuthProtoFinalizeMFATOTPEnrollmentRequestInfo.m?100.00%?
    FIRAuthProtoFinalizeMFATOTPEnrollmentResponseInfo.m?0.00%?
    FIRAuthProtoFinalizeMFATOTPSignInRequestInfo.m?100.00%?
    FIRAuthProtoMFAEnrollment.m?89.47%?
    FIRAuthProtoStartMFAPhoneRequestInfo.m?0.00%?
    FIRAuthProtoStartMFAPhoneResponseInfo.m?0.00%?
    FIRAuthProtoStartMFATOTPEnrollmentRequestInfo.m?100.00%?
    FIRAuthProtoStartMFATOTPEnrollmentResponseInfo.m?0.00%?
    FIRAuthRequestConfiguration.m?100.00%?
    FIRAuthSerialTaskQueue.m?100.00%?
    FIRAuthSettings.m?58.33%?
    FIRAuthStoredUserManager.m?52.87%?
    FIRAuthTokenResult.m?78.67%?
    FIRAuthURLPresenter.m?51.68%?
    FIRAuthUserDefaults.m?100.00%?
    FIRAuthWebUtils.m?95.51%?
    FIRAuthWebView.m?0.00%?
    FIRAuthWebViewController.m?0.00%?
    FIRCreateAuthURIRequest.m?61.29%?
    FIRCreateAuthURIResponse.m?100.00%?
    FIRDeleteAccountRequest.m?100.00%?
    FIRDeleteAccountResponse.m?100.00%?
    FIREmailAuthProvider.m?54.55%?
    FIREmailLinkSignInRequest.m?90.91%?
    FIREmailLinkSignInResponse.m?60.87%?
    FIREmailPasswordAuthCredential.m?34.04%?
    FIRFacebookAuthCredential.m?38.46%?
    FIRFacebookAuthProvider.m?37.50%?
    FIRFinalizeMFAEnrollmentRequest.m?64.29%?
    FIRFinalizeMFAEnrollmentResponse.m?0.00%?
    FIRFinalizeMFASignInRequest.m?87.50%?
    FIRFinalizeMFASignInResponse.m?0.00%?
    FIRGameCenterAuthCredential.m?0.00%?
    FIRGameCenterAuthProvider.m?0.00%?
    FIRGetAccountInfoRequest.m?100.00%?
    FIRGetAccountInfoResponse.m?80.00%?
    FIRGetOOBConfirmationCodeRequest.m?84.91%?
    FIRGetOOBConfirmationCodeResponse.m?100.00%?
    FIRGetProjectConfigRequest.m?100.00%?
    FIRGetProjectConfigResponse.m?64.29%?
    FIRGitHubAuthCredential.m?38.46%?
    FIRGitHubAuthProvider.m?37.50%?
    FIRGoogleAuthCredential.m?40.00%?
    FIRGoogleAuthProvider.m?37.50%?
    FIRIdentityToolkitRequest.m?91.67%?
    FIRMultiFactor.m?12.12%?
    FIRMultiFactorInfo.m?89.29%?
    FIRMultiFactorResolver.m?11.34%?
    FIRMultiFactorSession.m?0.00%?
    FIROAuthCredential.m?50.00%?
    FIROAuthProvider.m?85.93%?
    FIRPhoneAuthCredential.m?31.37%?
    FIRPhoneAuthProvider.m?56.02%?
    FIRPhoneMultiFactorAssertion.m?0.00%?
    FIRPhoneMultiFactorGenerator.m?0.00%?
    FIRPhoneMultiFactorInfo.m?86.36%?
    FIRResetPasswordRequest.m?89.47%?
    FIRResetPasswordResponse.m?100.00%?
    FIRRevokeTokenRequest.m?100.00%?
    FIRRevokeTokenResponse.m?100.00%?
    FIRSecureTokenRequest.m?56.82%?
    FIRSecureTokenResponse.m?0.00%?
    FIRSecureTokenService.m?91.39%?
    FIRSendVerificationCodeRequest.m?93.10%?
    FIRSendVerificationCodeResponse.m?57.14%?
    FIRSetAccountInfoRequest.m?96.61%?
    FIRSetAccountInfoResponse.m?100.00%?
    FIRSignInWithGameCenterRequest.m?100.00%?
    FIRSignInWithGameCenterResponse.m?100.00%?
    FIRSignUpNewUserRequest.m?94.44%?
    FIRSignUpNewUserResponse.m?100.00%?
    FIRStartMFAEnrollmentRequest.m?62.16%?
    FIRStartMFAEnrollmentResponse.m?0.00%?
    FIRStartMFASignInRequest.m?0.00%?
    FIRStartMFASignInResponse.m?0.00%?
    FIRTOTPMultiFactorAssertion.m?0.00%?
    FIRTOTPMultiFactorGenerator.m?0.00%?
    FIRTOTPMultiFactorInfo.m?0.00%?
    FIRTOTPSecret.m?0.00%?
    FIRTwitterAuthCredential.m?40.00%?
    FIRTwitterAuthProvider.m?37.50%?
    FIRUser.m?71.07%?
    FIRUserInfoImpl.m?93.75%?
    FIRUserMetadata.m?86.36%?
    FIRVerifyAssertionRequest.m?91.36%?
    FIRVerifyAssertionResponse.m?87.50%?
    FIRVerifyClientRequest.m?100.00%?
    FIRVerifyClientResponse.m?100.00%?
    FIRVerifyCustomTokenRequest.m?89.47%?
    FIRVerifyCustomTokenResponse.m?100.00%?
    FIRVerifyPasswordRequest.m?94.12%?
    FIRVerifyPasswordResponse.m?62.50%?
    FIRVerifyPhoneNumberRequest.m?82.76%?
    FIRVerifyPhoneNumberResponse.m?81.25%?
    FIRWithdrawMFARequest.m?0.00%?
    FIRWithdrawMFAResponse.m?0.00%?
    NSData+FIRBase64.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hCgSB2Tznh.html

@pragatimodi pragatimodi marked this pull request as draft July 15, 2023 00:39
@pragatimodi pragatimodi marked this pull request as ready for review July 24, 2023 21:58
@pragatimodi pragatimodi merged commit 931255b into master Jul 25, 2023
@pragatimodi pragatimodi deleted the shared-application-wrap branch July 25, 2023 01:01
@renkelvin renkelvin linked an issue Jul 25, 2023 that may be closed by this pull request
FirebaseAuth - sharedApplication is unavailable #11537
Closed
paulb777
paulb777 reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pragatimodi Thanks for making the fix! Would you update the CHANGELOG and associated issue as well?

@firebase firebase locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

@renkelvin renkelvin renkelvin approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FirebaseAuth - sharedApplication is unavailable
4 participants
@pragatimodi @google-oss-bot @paulb777 @renkelvin