Skip to content

Commit

Permalink
Fix typo of the Crashlytics c files (#13331)
Browse files Browse the repository at this point in the history
  • Loading branch information
MojtabaHs authored Jul 21, 2024
1 parent c0a952e commit feeeb27
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions Crashlytics/Crashlytics/Components/FIRCLSProcess.c
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ void FIRCLSProcessRecordDispatchQueueNames(FIRCLSProcess *process, FIRCLSFile *f
FIRCLSFileWriteSectionEnd(file);
}

#pragma mark - Othe Process Info
#pragma mark - Other Process Info
bool FIRCLSProcessGetMemoryUsage(uint64_t *active,
uint64_t *inactive,
uint64_t *wired,
Expand Down Expand Up @@ -782,7 +782,7 @@ static void FIRCLSProcessRecordCrashInfo(FIRCLSFile *file) {
FIRCLSSDKLogDebug("Found crash info with version %d\n", info.version);

// Currently support versions 0 through 5.
// 4 was in use for a long time, but it appears that with iOS 9 / swift 2.0, the verison has
// 4 was in use for a long time, but it appears that with iOS 9 / swift 2.0, the version has
// been bumped.
if (info.version > 5) {
continue;
Expand Down
4 changes: 2 additions & 2 deletions Crashlytics/Crashlytics/Handlers/FIRCLSException.mm
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ static void FIRCLSCatchAndRecordActiveException(std::type_info *typeInfo) {

// This is a funny technique to get the exception object. The inner @try
// has the ability to capture NSException-derived objects. It seems that
// c++ trys can do that in some cases, but I was warned by the WWDC labs
// c++ tries can do that in some cases, but I was warned by the WWDC labs
// that there are cases where that will not work (like for NSException subclasses).
try {
@try {
Expand All @@ -416,7 +416,7 @@ static void FIRCLSCatchAndRecordActiveException(std::type_info *typeInfo) {
FIRCLSExceptionRecord(FIRCLSExceptionTypeCpp, FIRCLSExceptionDemangle(name), exc->what(), nil,
nil);
} catch (const std::bad_alloc &exc) {
// it is especially important to avoid demangling in this case, because the expetation at this
// it is especially important to avoid demangling in this case, because the expectation at this
// point is that all allocations could fail
FIRCLSExceptionRecord(FIRCLSExceptionTypeCpp, "std::bad_alloc", exc.what(), nil, nil);
} catch (...) {
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Handlers/FIRCLSSignal.c
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ static void FIRCLSSignalInstallHandlers(FIRCLSSignalReadContext *roContext) {
void FIRCLSSignalCheckHandlers(void) {
if (_firclsContext.readonly->debuggerAttached) {
// Adding this log to remind user deattachs from the debugger. Besides FIRCLSSignal, this logic is on FIRCLSMachException and FIRCLSException as well. Only log once since the check is same.
FIRCLSSDKLog("[Crashlytics] App is attached to a debugger, to see the crash reports please deattach from the debugger, https://firebase.google.com/docs/crashlytics/get-started?platform=ios#force-test-crash");
FIRCLSSDKLog("[Crashlytics] App is attached to a debugger, to see the crash reports please detach from the debugger, https://firebase.google.com/docs/crashlytics/get-started?platform=ios#force-test-crash");
return;
}

Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Private/FIRStackFrame_Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ NS_ASSUME_NONNULL_BEGIN
* non-ObjC, non-C++, and non-Swift exceptions. All information included here will be displayed in
*the Crashlytics UI, and can influence crash grouping. Be particularly careful with the use of the
*address properties. If set, Crashlytics will attempt symbolication and could overwrite other
*properities in the process.
*properties in the process.
**/
@interface FIRStackFrame (Private)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ bool FIRCLSCompactUnwindLookupSecondLevelCompressed(FIRCLSCompactUnwindContext*

uint32_t entry = entryArray[index];

// Computing the fuction start address is easy
// Computing the function start address is easy
result->functionStart = UNWIND_INFO_COMPRESSED_ENTRY_FUNC_OFFSET(entry) +
FIRCLSCompactUnwindGetIndexFunctionOffset(context);

Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Unwind/Dwarf/FIRCLSDwarfUnwind.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ bool FIRCLSDwarfParseFDERecord(DWARFFDERecord* fdeRecord,
if (parseCIE) {
// The CIE offset is really weird. It appears to be an offset from the
// beginning of its field. This isn't what the documentation says, but it is
// a little ambigious. This is what DwarfParser.hpp does.
// a little ambiguous. This is what DwarfParser.hpp does.
// Note that we have to back up one sizeof(uint32_t), because we've advanced
// by parsing the offset
const void* ciePointer = ptr - fdeRecord->cieOffset - sizeof(uint32_t);
Expand Down
4 changes: 2 additions & 2 deletions Crashlytics/Crashlytics/Unwind/FIRCLSUnwind.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ bool FIRCLSUnwindFirstExecutableAddress(vm_address_t start,
vm_address_t end,
vm_address_t* foundAddress) {
// This function walks up the data on the stack, looking for the first value that is an address on
// an exectuable page. This is a heurestic, and can hit false positives.
// an executable page. This is a heurestic, and can hit false positives.

*foundAddress = 0; // write in a 0

Expand All @@ -304,7 +304,7 @@ bool FIRCLSUnwindFirstExecutableAddress(vm_address_t start,
}

FIRCLSSDKLogDebug("Checking for executable %p\n", (void*)address);
// when we find an exectuable address, we're finished
// when we find an executable address, we're finished
if (FIRCLSUnwindIsAddressExecutable(address)) {
*foundAddress = address;
return true;
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Unwind/FIRCLSUnwind_arm.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ bool FIRCLSDwarfUnwindSetRegisterValue(FIRCLSThreadContext* registers,
// Here's what's going on. For x86, the "return register" is virtual. The architecture
// doesn't actually have one, but DWARF does have the concept. So, when the system
// tries to set the return register, we set the PC. You can see this behavior
// in the FIRCLSDwarfUnwindSetRegisterValue implemenation for that architecture. In the
// in the FIRCLSDwarfUnwindSetRegisterValue implementation for that architecture. In the
// case of ARM64, the register is real. So, we have to be extra careful to make sure
// we update the PC here. Otherwise, when a DWARF unwind completes, it won't have
// changed the PC to the right value.
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/Crashlytics/Unwind/FIRCLSUnwind_x86.c
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ bool FIRCLSCompactUnwindRemapRegisters(const compact_unwind_encoding_t encoding,
// Re-number the registers

// You are probably wondering, what the hell is this algorithm even doing? It is
// taken from libunwind's implemenation that does the same thing.
// taken from libunwind's implementation that does the same thing.
bool used[7] = {false, false, false, false, false, false, false};
for (uint32_t i = 0; i < regCount; ++i) {
int renum = 0;
Expand Down

0 comments on commit feeeb27

Please sign in to comment.