fixes

firebase · Oct 1, 2024 · 8547d30 · 8547d30
1 parent 712cd7a
commit 8547d30
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/.github/workflows/installations.yml b/.github/workflows/installations.yml
@@ -55,7 +55,7 @@ jobs:
       run: |
        export FIS_INTEGRATION_TESTS_REQUIRED=${{ steps.secrets.outputs.val }}
        scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebaseInstallations.podspec \
-         --platforms=${{ matrix.target }} --test-specs=--platforms=${{ matrix.test-specs }}
+         --platforms=${{ matrix.target }} --test-specs=${{ matrix.test-specs }}
 
   spm-package-resolved:
     env:

diff --git a/FirebaseABTesting/Tests/Unit/ABTConditionalUserPropertyControllerTest.m b/FirebaseABTesting/Tests/Unit/ABTConditionalUserPropertyControllerTest.m
@@ -65,11 +65,9 @@ - (void)setUp {
 
   // Must initialize FIRApp before calling set experiment as Firebase Analytics internal event
   // logging requires it.
-  NSDictionary *optionsDictionary = @{
-    kFIRGoogleAppID : @"1:123456789012:ios:1234567890123456",
-    @"GCM_SENDER_ID" : @"123456789012"
-  };
-  FIROptions *options = [[FIROptions alloc] initInternalWithOptionsDictionary:optionsDictionary];
+  FIROptions *options =
+      [[FIROptions alloc] initWithGoogleAppID:@"1:123456789012:ios:1234567890123456"
+                                  GCMSenderID:@"123456789012"];
   [FIRApp configureWithOptions:options];
 }
 

diff --git a/FirebaseInstallations/Source/Tests/Unit/FIRInstallationsIDControllerTests.m b/FirebaseInstallations/Source/Tests/Unit/FIRInstallationsIDControllerTests.m
@@ -97,12 +97,10 @@ - (void)tearDown {
 #pragma mark - Initialization
 
 - (void)testInitWhenProjectIDSetThenItIsPassedToAPIService {
-  FIROptions *options = [[FIROptions alloc] initInternalWithOptionsDictionary:@{
-    kFIRAPIKey : @"api-key",
-    kFIRProjectID : @"project-id",
-    kFIRGoogleAppID : @"app-id",
-    kFIRGCMSenderID : @"sender-id"
-  }];
+  FIROptions *options = [[FIROptions alloc] initWithGoogleAppID:@"app-id" GCMSenderID:@"sender-id"];
+  options.projectID = @"project-id";
+  options.APIKey = @"api-key";
+
   FIRApp *app = [[FIRApp alloc] initInstanceWithName:@"app-name" options:options];
 
   OCMExpect([self.mockAPIService alloc]).andReturn(self.mockAPIService);